[ 
https://issues.apache.org/jira/browse/HCATALOG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155583#comment-13155583
 ] 

[email protected] commented on HCATALOG-160:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2809/#review3449
-----------------------------------------------------------



storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseDirectOutputStorageDriver.java
<https://reviews.apache.org/r/2809/#comment7705>

    Shouldn't this be done within super.initialize() Once the outputJobInfo is 
updated with revision String in HBaseBaseOutputStorageDriver, it needs to be 
overwritten in configuration there only.


- Ashutosh


On 2011-11-11 18:24:59, Francis Liu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2809/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-11 18:24:59)
bq.  
bq.  
bq.  Review request for hcatalog, Sushanth Sowmyan, Vandana Ayyalasomayajula, 
and David Capwell.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  HBaseDirectOutputStorageDriver missed serializing the updated 
OutputJobInfo, fixed that.
bq.  
bq.  
bq.  This addresses bug hcatalog-160.
bq.      https://issues.apache.org/jira/browse/hcatalog-160
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseDirectOutputStorageDriver.java
 65dfccb 
bq.    
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
 c25e56d 
bq.    
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputStorageDriver.java
 d612584 
bq.  
bq.  Diff: https://reviews.apache.org/r/2809/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Updated unit tests to such a scenario and it passes now.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Francis
bq.  
bq.


                
> HBaseDirectOutputStorageDriver outputVersion isn't consitent within the same 
> MR job
> -----------------------------------------------------------------------------------
>
>                 Key: HCATALOG-160
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-160
>             Project: HCatalog
>          Issue Type: Bug
>          Components: storage handlers
>    Affects Versions: 0.3
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>              Labels: hbase, storage_drivers
>             Fix For: 0.3
>
>         Attachments: HCATALOG-160.patch, HCATALOG-160_svn.patch
>
>
> a single MR job should use the same revision number, the bug causes a new one 
> to be made for each mapper

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to