----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3775/#review4867 -----------------------------------------------------------
src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java <https://reviews.apache.org/r/3775/#comment10704> It seems odd to put this into the o.a.hadoop.mapred package. Are you calling some package scoped function or something? src/java/org/apache/hcatalog/common/HCatUtil.java <https://reviews.apache.org/r/3775/#comment10708> Some javadoc here on what should be passed into each of these values would be helpful. They are class names I assume? src/java/org/apache/hcatalog/common/HCatUtil.java <https://reviews.apache.org/r/3775/#comment10709> We shouldn't need code at all to pull out ISD and OSD info, since we're removing them, correct? So I'm confused why a new function is being added here to pull that info out. src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java <https://reviews.apache.org/r/3775/#comment10723> What is better that needs to be put here? src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java <https://reviews.apache.org/r/3775/#comment10737> We should add this before we commit the patch, as it should speed things up quite a bit. src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java <https://reviews.apache.org/r/3775/#comment10740> Some javadoc on the purpose of this class would be good. I'm assuming the purpose is to be a stand in StorageHandler in the HDFS storage case where there isn't a storage handler. Once we have moved getAuthorizationProvider from HCatStorageHandler to HiveStorageHandler will this class extend HiveStorageHandler? - Alan On 2012-02-07 17:27:58, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3775/ > ----------------------------------------------------------- > > (Updated 2012-02-07 17:27:58) > > > Review request for hcatalog, Alan Gates and Sushanth Sowmyan. > > > Summary > ------- > > First drop. See HCATALOG-240. > > > This addresses bug HCATALOG-240. > https://issues.apache.org/jira/browse/HCATALOG-240 > > > Diffs > ----- > > src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java > f37c5fd > src/java/org/apache/hcatalog/mapreduce/DefaultOutputFormatContainer.java > 13fa8ac > src/java/org/apache/hcatalog/mapreduce/DefaultRecordWriterContainer.java > 7c90737 > src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java > 9c5fdd3 > src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java PRE-CREATION > src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java > 9d98f50 > src/java/org/apache/hcatalog/common/HCatUtil.java 13b56fd > src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java > e91ed0f > src/java/org/apache/hcatalog/mapreduce/FileOutputStorageDriver.java 6596264 > src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java > c72cb4f > src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java > PRE-CREATION > src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 1b2f9a4 > src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java 90c5671 > src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java.broken > PRE-CREATION > src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java 1ba8ccd > src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java.broken > PRE-CREATION > src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java ed1ba66 > src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java.broken > PRE-CREATION > src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java d7eab9e > src/java/org/apache/hcatalog/mapreduce/HCatOutputStorageDriver.java 566943f > src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java PRE-CREATION > src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java e65f1d0 > src/java/org/apache/hcatalog/mapreduce/OutputCommitterContainer.java > 5f0585a > src/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java f73a6dc > src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 9830190 > src/java/org/apache/hcatalog/mapreduce/ProgressReporter.java PRE-CREATION > src/java/org/apache/hcatalog/mapreduce/RecordWriterContainer.java 9a93bfa > src/java/org/apache/hcatalog/mapreduce/StorerInfo.java 8785ffb > src/java/org/apache/hcatalog/pig/HCatEximLoader.java a36f808 > src/java/org/apache/hcatalog/pig/HCatEximLoader.java.broken PRE-CREATION > src/java/org/apache/hcatalog/pig/HCatEximStorer.java b7bee44 > src/java/org/apache/hcatalog/pig/HCatEximStorer.java.broken PRE-CREATION > src/test/org/apache/hcatalog/cli/DummyStorageHandler.java 0e9565c > src/test/org/apache/hcatalog/cli/TestStorageHandlerProperties.java df8f5a5 > src/test/org/apache/hcatalog/cli/TestStorageHandlerProperties.java.broken > PRE-CREATION > src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java 9d94c7b > src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java.broken > PRE-CREATION > src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java > 99ec02b > src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java.broken > PRE-CREATION > src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java 5df0146 > src/test/org/apache/hcatalog/pig/TestHCatEximLoader.java 7691fb9 > src/test/org/apache/hcatalog/pig/TestHCatEximLoader.java.broken > PRE-CREATION > src/test/org/apache/hcatalog/pig/TestHCatEximStorer.java c3ba19d > src/test/org/apache/hcatalog/pig/TestHCatEximStorer.java.broken > PRE-CREATION > storage-drivers/build.xml efd26d0 > > Diff: https://reviews.apache.org/r/3775/diff > > > Testing > ------- > > > Thanks, > > Francis > >
