[
https://issues.apache.org/jira/browse/HCATALOG-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209503#comment-13209503
]
[email protected] commented on HCATALOG-239:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3901/#review5161
-----------------------------------------------------------
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11286>
This looks like it came from my patch. I've updated my patch and moved this
into InternalUtil. Please update.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11287>
comments don't match the method.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11288>
This should probably be moved to internal util?
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11294>
You don't really need the user to specify a class do you? I think you can
arbitrarily pick one for HiveConf preferably one from the hive client library.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11289>
include the original exception as part of the new throw exception. provide
a better message.
trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/3901/#comment11290>
Sushanth has this in his patch as well...a more updated version I think.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11291>
We might as well fix this...better to throw the specific exception,
IOException. This should break backwards compatibility.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11292>
Might as well fix this too.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11293>
maybe call it getMapRedInputFormat(), to make things clearer.
Is this used beyond this class? Consider making it private or package
private.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11295>
Are you sure tableDesc.getJobProperties() hasn't been set you prior to this?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11296>
Add a message.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
<https://reviews.apache.org/r/3901/#comment11299>
change to private?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java
<https://reviews.apache.org/r/3901/#comment11300>
this class was removed in my patch. please update.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11301>
shouldn't the contents of this be moved into mapreduce.initializ()?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11302>
you should probably throw an exception if it's not an hcatsplit.
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11304>
add a message
trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
<https://reviews.apache.org/r/3901/#comment11303>
i'm wondering wether you should actually throw an exception as well. since
the underlying inputformat did so itself?
trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java
<https://reviews.apache.org/r/3901/#comment11306>
shouldn't this be a mapreduce.InputSplit?
- Francis
On 2012-02-14 22:21:47, Vikram Dixit Kumaraswamy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3901/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 22:21:47)
bq.
bq.
bq. Review request for Alan Gates, Sushanth Sowmyan and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch with input format specific changes integrated with record
reader and output format changes.
bq.
bq.
bq. This addresses bug HCATALOG-239.
bq. https://issues.apache.org/jira/browse/HCATALOG-239
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1241662
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1241662
bq.
bq. Diff: https://reviews.apache.org/r/3901/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Vikram
bq.
bq.
> Changes to HCatInputFormat to make it use SerDes instead of StorageDrivers
> --------------------------------------------------------------------------
>
> Key: HCATALOG-239
> URL: https://issues.apache.org/jira/browse/HCATALOG-239
> Project: HCatalog
> Issue Type: Sub-task
> Components: storage handlers
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Vikram Dixit K
> Fix For: 0.4
>
> Attachments: 239.patch, 239_1.patch, 239_2.patch, 239_3.patch
>
>
> This JIRA covers changes to HCatInputFormat and InputJobInfo. See
> HCATALOG-237 for details and design notes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
