----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3846/#review5186 -----------------------------------------------------------
Ship it! +1 Running tests, will commit if tests pass. - Ashutosh On 2012-02-17 02:28:01, enis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3846/ > ----------------------------------------------------------- > > (Updated 2012-02-17 02:28:01) > > > Review request for hcatalog. > > > Summary > ------- > > As per the design in the parent issue, we will delegate the authorization > checks to the storage handler (hdfs is considered as a storage handler as > well). This jira will introduce HiveAuthorizationProviders for hbase + hdfs. > > > This addresses bug HCATALOG-245. > https://issues.apache.org/jira/browse/HCATALOG-245 > > > Diffs > ----- > > src/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java > PRE-CREATION > > src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java > PRE-CREATION > src/java/org/apache/hcatalog/common/AuthUtils.java 7cba8dc > src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java > 8387d8e > conf/proto-hive-site.xml 4251c2a > src/java/org/apache/hcatalog/cli/SemanticAnalysis/AddPartitionHook.java > efbb79a > src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java > 109de31 > src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java > 098a06b > > src/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java > PRE-CREATION > src/test/excluded-tests 8b13789 > src/test/org/apache/hcatalog/HcatTestUtils.java PRE-CREATION > src/test/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3846/diff > > > Testing > ------- > > > Thanks, > > enis > >
