----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4322/#review5917 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java <https://reviews.apache.org/r/4322/#comment12875> nitpick: use getProperty isntead so you don't have to cast it to string. http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java <https://reviews.apache.org/r/4322/#comment12876> nitpick: since you're changing this can you fix the formatting? :-) http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java <https://reviews.apache.org/r/4322/#comment12881> I'd rather add it directly to JobConf. That way it's less of a hack and less dependent on an unplanned behavior. http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java <https://reviews.apache.org/r/4322/#comment12880> add a TODO to remove this once HCAT-308 is fixed. http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java <https://reviews.apache.org/r/4322/#comment12877> Does this work without the foolproof code? Let's try to contain the bug with pig in HCatStorer. It'll just add more complexity. http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java <https://reviews.apache.org/r/4322/#comment12879> shouldn't you add it to copy? for the output you don't need the hack of changing conf do you? - Francis On 2012-03-14 01:07:44, Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4322/ > ----------------------------------------------------------- > > (Updated 2012-03-14 01:07:44) > > > Review request for hcatalog, Alan Gates, Francis Liu, and Vandana > Ayyalasomayajula. > > > Summary > ------- > > Fixes to get Hbase storagehandler working with Pig. > > > 1)Includes changes to HCatStorer used by Pig. Modified HCatStorer to pass the > same OutputJobInfo in the multiple calls made in Pig to > HCatOutputFormat.setOutput. Else we ended up creating multiple orphaned > transactions which were never committed in zookeeper. > 2) Moved stuff from getInputSplits and checkoutputSpecs to configure methods > in storagehandler. > 3) Fixed a logic error in hbase record reader. > > > This addresses bug HCATALOG-302. > https://issues.apache.org/jira/browse/HCATALOG-302 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseDirectOutputFormat.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HbaseSnapshotRecordReader.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java > 1299921 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputFormat.java > 1299921 > > Diff: https://reviews.apache.org/r/4322/diff > > > Testing > ------- > > Unit tests and Integration testing done. > > > Thanks, > > Rohini > >
