----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4281/#review5973 -----------------------------------------------------------
Ship it! minor nitpick unit tests passed. /trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java <https://reviews.apache.org/r/4281/#comment12953> you can use HCatOutputFormat.getJobInfo() - Francis On 2012-03-14 20:48:18, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4281/ > ----------------------------------------------------------- > > (Updated 2012-03-14 20:48:18) > > > Review request for hcatalog, Francis Liu, David Capwell, and Rohini > Palaniswamy. > > > Summary > ------- > > Creating a table stored a sequence file and trying to write data into it > using Pig or MR fails with NPE. > > > Diffs > ----- > > > /trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java > 1300711 > > /trunk/src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java > 1300711 > > /trunk/src/test/org/apache/hcatalog/mapreduce/TestSequenceFileReadWrite.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4281/diff > > > Testing > ------- > > Unit tests added and they pass. > > > Thanks, > > Vandana > >
