[
https://issues.apache.org/jira/browse/HCATALOG-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235086#comment-13235086
]
[email protected] commented on HCATALOG-301:
--------------------------------------------------------
bq. On 2012-03-21 19:08:35, Vandana Ayyalasomayajula wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java,
line 433
bq. > <https://reviews.apache.org/r/4416/diff/2/?file=94212#file94212line433>
bq. >
bq. > This method should convert the dbname.tablename to lower case. Any
user should be using this method get obtain table names, so that we do not run
into errors.
Need to maintain case for working with external hbase tables that were created
with uppercase name.
bq. On 2012-03-21 19:08:35, Vandana Ayyalasomayajula wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java,
line 417
bq. > <https://reviews.apache.org/r/4416/diff/2/?file=94212#file94212line417>
bq. >
bq. > Do we need this additional method ? Can we do,
getFullyQualifiedHBaseTableName(HCatTableInfo.valueOf(tbl).
bq. >
bq. > Also, can in my opinion we should be using only lower case names. So
"deafult.Mytable" should be equivalent to "default.mytable". The nodes in the
revision manager will have the fully qualified name ( in lower case).
Can do. But it will save on the additional copying and construction of objects.
We already have too much of that in the code.
We need to maintain the case of the hbase tables. If we are handling only lower
case then we cannot work with external hbase tables.
bq. On 2012-03-21 19:08:35, Vandana Ayyalasomayajula wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java,
line 103
bq. > <https://reviews.apache.org/r/4416/diff/2/?file=94212#file94212line103>
bq. >
bq. > The copyOfConf is based on jobConf, which has hbase defaults in it.
So you don't have to do
HBaseConfiguration.addHbaseResources(copyOfConf); again.
The jobConf does not have the defaults added in them. If the defaults are added
to the the jobConf directly then any overrides set in the job for hbase will
not apply. For eg: The unit tests have different zookeeper port set in jobConf.
But if hbase-default.xml is added to it, it overrides it with default port.
That's why resorting to this.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4416/#review6177
-----------------------------------------------------------
On 2012-03-21 18:18:10, Rohini Palaniswamy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4416/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-21 18:18:10)
bq.
bq.
bq. Review request for Francis Liu and Vandana Ayyalasomayajula.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Introduced a new table property "hbase.table.name" similar to Hive to
store hbase table names retaining the case. This will be used to access hbase
and zookeeper which are case sensitive from within the HbaseHCatStorageHandler.
bq.
bq. Added two new APIs setupTable and dropTable to RevisionManager and removed
public APIs for setting up and dropping znodes in ZKBasedRevisionManager.
bq.
bq.
bq. This addresses bug HCATALOG-301.
bq. https://issues.apache.org/jira/browse/HCATALOG-301
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
1303371
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
1303371
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKBasedRevisionManager.java
1303371
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java
1303371
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java
1303371
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseHCatStorageHandler.java
1303371
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputFormat.java
1303371
bq.
bq. Diff: https://reviews.apache.org/r/4416/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests added
bq.
bq.
bq. Thanks,
bq.
bq. Rohini
bq.
bq.
> Reading from a table created with upper case table name throws error
> --------------------------------------------------------------------
>
> Key: HCATALOG-301
> URL: https://issues.apache.org/jira/browse/HCATALOG-301
> Project: HCatalog
> Issue Type: Bug
> Components: hbase
> Affects Versions: 0.4
> Reporter: David Capwell
> Assignee: Rohini Palaniswamy
> Fix For: 0.4.1
>
> Attachments: HCATALOG-301.patch
>
>
> if you create a new table then try to read from it, you will get the
> exception below. Ether the error should propagate up and be clear what
> happened (no data to read) or the job should run with empty input (fail fast
> imo).
> ERROR 18:29:05,057 [main] Launcher:171 - Backend error message during job
> submission
> org.apache.pig.backend.executionengine.ExecException: ERROR 2118:
> java.lang.IllegalStateException: Error while configuring job properties
> at
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat.getSplits(PigInputFormat.java:280)
> at
> org.apache.hadoop.mapred.JobClient.writeNewSplits(JobClient.java:962)
> [...]
> Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
> KeeperErrorCode = NoNode for
> /revision-management/data/hcatreadhbasetabletest_85330477246989847.hcatreadhbasetabletest_85330477285774847
> at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1448)
> at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1476)
> at
> org.apache.hcatalog.hbase.snapshot.ZKUtil.getColumnFamiliesOfTable(ZKUtil.java:130)
> ... 25 more
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
