[
https://issues.apache.org/jira/browse/HCATALOG-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235882#comment-13235882
]
[email protected] commented on HCATALOG-310:
--------------------------------------------------------
bq. On 2012-03-22 18:42:09, Francis Liu wrote:
bq. > some small changes I can fix on checkin. do you plan to work on
deployment in a separate jira? I'd also like to have all the unit tests use
this by default. and have this our main way of deployment.
Yes, will make separate JIRA that will also deal with making e2e tests work
(need solution to deploy endpoint to hbase), at which point we can switch
default.
bq. On 2012-03-22 18:42:09, Francis Liu wrote:
bq. >
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java,
line 49
bq. > <https://reviews.apache.org/r/4313/diff/4/?file=93924#file93924line49>
bq. >
bq. > this constant should be defined in this class. since it is specific
to this.
It logically belongs there, but we should also think of having a central place
that lists all available settings (something like HConstants).
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4313/#review6243
-----------------------------------------------------------
On 2012-03-20 19:59:40, Thomas wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4313/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-20 19:59:40)
bq.
bq.
bq. Review request for Francis Liu, Vandana Ayyalasomayajula and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial patch for RevisionManager endpoint.
bq.
bq.
bq. This addresses bug HCATALOG-310.
bq. https://issues.apache.org/jira/browse/HCATALOG-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseRevisionManagerUtil.java
1302742
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
1302742
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpointClient.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
1302742
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerProtocol.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/TableSnapshot.java
1302742
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/package-info.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/ManyMiniCluster.java
1302742
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/SkeletonHBaseTest.java
1302742
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerEndpoint.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4313/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Turn current RM implementation into HBase Coprocessor
> -----------------------------------------------------
>
> Key: HCATALOG-310
> URL: https://issues.apache.org/jira/browse/HCATALOG-310
> Project: HCatalog
> Issue Type: Sub-task
> Components: hbase, storage handlers
> Affects Versions: 0.4
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Fix For: 0.5, 0.4.1
>
> Attachments: HCATALOG-310.3.patch
>
>
> Implement initial revision of endpoint and add new implementation of existing
> RM interface for HBase endpoint client. Add option to configure RM as
> endpoint. This will leave current default behavior as is (ZK based RM running
> per client in storage handler).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
