----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4492/ -----------------------------------------------------------
Review request for hcatalog, Alan Gates and Sushanth Sowmyan.
Summary
-------
Additional svn command (not part of the patch):
svn mv src/java/org/apache/hcatalog/pig/drivers/StoreFuncBasedOutputDriver.java
src/java/org/apache/hcatalog/pig/drivers/StoreFuncBasedOutputDriver.java.broken
svn mv src/java/org/apache/hcatalog/pig/drivers/LoadFuncBasedInputDriver.java
src/java/org/apache/hcatalog/pig/drivers/LoadFuncBasedInputDriver.java.broken
svn mv src/java/org/apache/hcatalog/pig/drivers/PigStorageInputDriver.java
src/java/org/apache/hcatalog/pig/drivers/PigStorageInputDriver.java.broken
svn mv src/test/org/apache/hcatalog/rcfile/TestRCFileInputStorageDriver.java
src/test/org/apache/hcatalog/rcfile/TestRCFileInputStorageDriver.java.broken
svn mv src/test/org/apache/hcatalog/rcfile/TestRCFileOutputStorageDriver.java
src/test/org/apache/hcatalog/rcfile/TestRCFileOutputStorageDriver.java.broken
Changes:
1) Removed HCatInputStorageDriver and HCatOutputStorageDriver and removed any
references to them in the code.
2) Started rewriting testcases in TestRCFileInputStorageDriver and
TestRCFileOutputStorageDriver, but have not gotten around to completing them.
Holding on to this patch because of that for sometime. So renaming those tests
as .broken for now and will address the broken tests in a separate JIRA.
This addresses bug HCATALOG-268.
https://issues.apache.org/jira/browse/HCATALOG-268
Diffs
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/common/ErrorType.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/common/HCatConstants.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputFormatContainer.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputStorageDriver.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/HCatInputStorageDriver.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputStorageDriver.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/StorerInfo.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/rcfile/RCFileInputDriver.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/rcfile/RCFileOutputDriver.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/PartitionStorageDriverAnnotator.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/pig/MyPigStorage.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
1305484
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java
1305484
Diff: https://reviews.apache.org/r/4492/diff
Testing
-------
Unit tests pass
Thanks,
Rohini
