[
https://issues.apache.org/jira/browse/HCATALOG-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244275#comment-13244275
]
[email protected] commented on HCATALOG-36:
-------------------------------------------------------
bq. On 2012-03-30 23:01:38, David Capwell wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java,
lines 115-116
bq. > <https://reviews.apache.org/r/4437/diff/2/?file=97633#file97633line115>
bq. >
bq. > Why call a static method each time? Could this not be a instance
method? What about using the KeyValue class directly and just writing that to
context?
KeyValue class is internal to MultiOutputFormat. It is more clean and easy for
the user when he passes the key and value that he is working with rather than
constructing objects and passing them.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4437/#review6594
-----------------------------------------------------------
On 2012-03-30 16:36:00, Rohini Palaniswamy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4437/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 16:36:00)
bq.
bq.
bq. Review request for hcatalog, Owen O'Malley, Ranjit Mathew, and Alejandro
Abdelnur.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Patch description
bq. 1) Created a Generic MultiOutputFormat instead of a hcat specific
MultiTableOutputFormat that can be later ported to mapreduce.
bq. Classes - MultiOutputFormat.java, TestMultiOutputFormat.java. HCat
related tests for MultiOutputFormat in TestHCatMultiOutputFormat.java
bq. 2) Added closeHiveClientQuietly() as unit tests were failing because of
HIVE-2883/HCATALOG-236
bq. 3) Added setting file permissions correctly for the output files in
addition to the partition directory in FileOutputCommitterContainer. This was
required with multiple tables.
bq.
bq.
bq. This addresses bug HCATALOG-36.
bq. https://issues.apache.org/jira/browse/HCATALOG-36
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
1307252
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1307252
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1307252
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
1307252
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
1307252
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestMultiOutputFormat.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4437/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit and integration tested.
bq.
bq.
bq. Thanks,
bq.
bq. Rohini
bq.
bq.
> Support Writing Out to Multiple Tables in HCatOutputFormat
> ----------------------------------------------------------
>
> Key: HCATALOG-36
> URL: https://issues.apache.org/jira/browse/HCATALOG-36
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.2
> Reporter: Ranjit Mathew
> Assignee: Rohini Palaniswamy
> Attachments: HCATALOG-36-1.patch, HCATALOG-36.patch, multihcat.tgz
>
>
> HCatOutputFormat does not support writing out to multiple tables (or
> partitions for that matter).
> Add this support to HCatalog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
