[
https://issues.apache.org/jira/browse/HCATALOG-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252131#comment-13252131
]
[email protected] commented on HCATALOG-69:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4705/
-----------------------------------------------------------
Review request for hcatalog, Ashutosh Chauhan and Sushanth Sowmyan.
Summary
-------
Cleaned up a bit and move some redundant code in the Security.java to have
better encapsulation of security stuff. Removed jt token cancellation as this
will be taken care of by jt.
This addresses bug HCATALOG-69.
https://issues.apache.org/jira/browse/HCATALOG-69
Diffs
-----
src/java/org/apache/hcatalog/common/HCatConstants.java 264ecbd
src/java/org/apache/hcatalog/common/HCatUtil.java 46af296
src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
69e12f3
src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 5bb46d1
src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java a48332a
src/java/org/apache/hcatalog/mapreduce/Security.java db998a1
src/java/org/apache/hcatalog/pig/HCatStorer.java 34d8ec3
Diff: https://reviews.apache.org/r/4705/diff
Testing
-------
e2e tests pass (except for hbase related ones, need to fix my harness)
Thanks,
Francis
> Fix token usage from HCat
> -------------------------
>
> Key: HCATALOG-69
> URL: https://issues.apache.org/jira/browse/HCATALOG-69
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Francis Liu
> Attachments: HCATALOG-69.patch
>
>
> We need to fix the following issues in HCat
> + Token cancellation semantics of the Hive token needs storing the
> signature - rework to remove this
> + Likewise, there's no good need for the token signature and tokenstrform
> of the JobTracker token, and that might actually be a security problem there.
> That needs to be reworked to just scan tokens in current scope, and if found,
> and we have a flag set to indicate that it was a token we fetched, then we
> cancel as-is. Current code mimics hive-token behaviour and needs to be
> changed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
