----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4705/#review6889 -----------------------------------------------------------
Ship it! Build failure not an issue. Passed after I did a svn up with Alan's all night changes. - Rohini On 2012-04-12 01:43:58, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4705/ > ----------------------------------------------------------- > > (Updated 2012-04-12 01:43:58) > > > Review request for hcatalog, Ashutosh Chauhan and Sushanth Sowmyan. > > > Summary > ------- > > Cleaned up a bit and move some redundant code in the Security.java to have > better encapsulation of security stuff. Removed jt token cancellation as this > will be taken care of by jt. > > > This addresses bug HCATALOG-69. > https://issues.apache.org/jira/browse/HCATALOG-69 > > > Diffs > ----- > > src/java/org/apache/hcatalog/common/HCatConstants.java 264ecbd > src/java/org/apache/hcatalog/common/HCatUtil.java 46af296 > src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java > 69e12f3 > src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 5bb46d1 > src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java a48332a > src/java/org/apache/hcatalog/mapreduce/Security.java db998a1 > src/java/org/apache/hcatalog/pig/HCatStorer.java 34d8ec3 > > Diff: https://reviews.apache.org/r/4705/diff > > > Testing > ------- > > e2e tests pass (except for hbase related ones, need to fix my harness) > > > Thanks, > > Francis > >
