[
https://issues.apache.org/jira/browse/HCATALOG-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255806#comment-13255806
]
[email protected] commented on HCATALOG-363:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4701/
-----------------------------------------------------------
(Updated 2012-04-17 18:24:45.529279)
Review request for hcatalog.
Changes
-------
Updated the patch to recent revision and fixed conflict in
HCatBaseOutputFormat.
Summary
-------
Changes done:
1) Ensured that whenever there is a createHiveMetastoreClient there is a
close() so that connections are released.
2) Tried to close the connections quietly. Does not have much effect as of now
as HiveMetaStoreClient already catches the exception and does a LOG.error. So
the stack trace still appears in the logs.
This addresses bug HCATALOG-363.
https://issues.apache.org/jira/browse/HCATALOG-363
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatUtil.java
1327178
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1327178
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1327178
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
1327178
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1327178
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1327178
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/PigHCatUtil.java
1327178
Diff: https://reviews.apache.org/r/4701/diff
Testing
-------
Unit tests pass. Did an integration test issuing pig commands. e2e tests not
run.
Thanks,
Rohini
> HCat leaks metastore connection
> -------------------------------
>
> Key: HCATALOG-363
> URL: https://issues.apache.org/jira/browse/HCATALOG-363
> Project: HCatalog
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Ashutosh Chauhan
> Assignee: Rohini Palaniswamy
> Attachments: HCATALOG-363.patch
>
>
> PigHCatUtil::getTable() creates a metastore client but never call close on
> it. As a result, underlying connection will not be released. Metastore client
> is created in multiple different files, all of those should be examined to
> make sure, client is properly closed at the end.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
