----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4861/#review7201 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/pig/TestHCatStorer.java <https://reviews.apache.org/r/4861/#comment15906> instead of having another column added ( the 'g' column'), can we have the input[2] have the f column null, so that it tests your case. Like: input[i++]= i + "\t" + i * 2.1f +"\t"+ i*1.1d + "\t" + i * 2L +"\t"+"lets hcat"; - Vandana On 2012-04-24 22:07:18, Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4861/ > ----------------------------------------------------------- > > (Updated 2012-04-24 22:07:18) > > > Review request for hcatalog. > > > Summary > ------- > > Fixed the NPE > > > This addresses bug HCATALOG-382. > https://issues.apache.org/jira/browse/HCATALOG-382 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/PigHCatUtil.java > 1329472 > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/pig/TestHCatStorer.java > 1329472 > > Diff: https://reviews.apache.org/r/4861/diff > > > Testing > ------- > > Unit test added. > > > Thanks, > > Rohini > >
