> On 2012-04-26 18:46:24, David Capwell wrote: > > /trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java, line 9 > > <https://reviews.apache.org/r/4732/diff/5/?file=102447#file102447line9> > > > > I don't see why this is needed. List.toString will print out what you > > want, just not on a newline (just add \n{} if thats what you want). Same > > with Set. > > Vandana Ayyalasomayajula wrote: > What you are saying is true. This class is more like a place holder for > any future utility methods. I agree we can the slf4j log itself to log lists > and maps. The methods in the utility class will be efficient in terms, that > "isLogDebugEnabled" checks are done only once for all the items in the list.
"This class is more like a place holder for any future utility methods" IMO we should only add it once needed. "The methods in the utility class will be efficient in terms, that "isLogDebugEnabled" checks are done only once for all the items in the list." they are done n+2 times now (your call, once for the user's string, then n times for number of elements). If n is large this will be more IO than just calling toString on the list directly (logback is better about this but we are using log4j). The thing about slf4j is that it will only expand the args iff you are able to do it at that level and only calls toString, so these method are in fact more costly. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4732/#review7270 ----------------------------------------------------------- On 2012-04-26 20:34:16, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4732/ > ----------------------------------------------------------- > > (Updated 2012-04-26 20:34:16) > > > Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas. > > > Summary > ------- > > We need to do the following things: > > + Use log4j across the board > + Introduce a class with methods to help logging, refactoring away the bunch > of these functions in HCatUtil right now > + Instrument debug logging with isLogEnabled checks on the log level > + remove all instances of commented code whose purpose was for debug logs > > > This addresses bug hcatalog-68. > https://issues.apache.org/jira/browse/hcatalog-68 > > > Diffs > ----- > > > /trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java > 1331003 > /trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1331003 > /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java > 1331003 > > /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java > 1331003 > /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1331003 > /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1331003 > > /trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java > 1331003 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 1331003 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1331003 > /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1331003 > /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1331003 > /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1331003 > > Diff: https://reviews.apache.org/r/4732/diff > > > Testing > ------- > > Unit tests pass. Log messages verified from test logs. > > > Thanks, > > Vandana > >
