[ 
https://issues.apache.org/jira/browse/HCATALOG-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269823#comment-13269823
 ] 

David Capwell commented on HCATALOG-403:
----------------------------------------

+1

The only thing that could be a problem is the call to "needsTaskCommit" happens 
twice.  This shouldn't be a real issue but something to note.  Can you add to 
the java docs that this happens?
                
> MultiOutputFormat will call taskCommit on all formats if only one ever needs 
> commit
> -----------------------------------------------------------------------------------
>
>                 Key: HCATALOG-403
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-403
>             Project: HCatalog
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 0.4, 0.5, 0.4.1
>            Reporter: David Capwell
>            Assignee: Rohini Palaniswamy
>         Attachments: HCATALOG-403-1.patch, HCATALOG-403.patch
>
>
> If your output format's committer returns taskCommit=false but another 
> format's committer returns taskCommit=true then all committers will get 
> called in taskCommit phase

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to