----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5601/#review8649 -----------------------------------------------------------
Ship it! Looks good, and has the changes I requested for from the last time I had a look at it. +1 - Sushanth Sowmyan On June 27, 2012, 12:17 a.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5601/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 12:17 a.m.) > > > Review request for hcatalog and Sushanth Sowmyan. > > > Description > ------- > > Finish migration to slf4j for HCatalog logging. > > > Diffs > ----- > > build-common.xml dd30e79 > ivy.xml d505873 > ivy/libraries.properties 328a56a > src/java/org/apache/hcatalog/data/LazyHCatRecord.java 1e8c40d > src/java/org/apache/hcatalog/har/HarOutputCommitterPostProcessor.java > 007acb2 > src/java/org/apache/hcatalog/listener/NotificationListener.java 6f2759d > src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java > 62e56fa > src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java c74748b > src/java/org/apache/hcatalog/mapreduce/Security.java b0b26dc > src/java/org/apache/hcatalog/rcfile/RCFileMapReduceOutputFormat.java > c476d0d > src/test/e2e/hcatalog/tools/generate/generate_data.pl 8fb206d > src/test/org/apache/hcatalog/HcatTestUtils.java f43200d > src/test/org/apache/hcatalog/mapreduce/HCatBaseTest.java 2dbe769 > storage-handlers/hbase/ivy.xml 85185f6 > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseRevisionManagerUtil.java > 2b62ea8 > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HbaseSnapshotRecordReader.java > 686c2b1 > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java > 95e38e2 > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/IDGenerator.java > 01873bc > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKBasedRevisionManager.java > dca828c > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKUtil.java > 016e4b2 > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/lock/ProtocolSupport.java > 3043d3a > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/lock/WriteLock.java > cc2cf2a > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/lock/ZNodeName.java > ec7e831 > > storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java > 8c0a979 > > Diff: https://reviews.apache.org/r/5601/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
