[
https://issues.apache.org/jira/browse/HCATALOG-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402659#comment-13402659
]
Travis Crawford commented on HCATALOG-437:
------------------------------------------
+1
Nit: I prefer to follow the java style guide and use braces for all if
statements.
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449
> HCatSchema's equals() implementation uses hashcode obtained from toString()
> method.
> -----------------------------------------------------------------------------------
>
> Key: HCATALOG-437
> URL: https://issues.apache.org/jira/browse/HCATALOG-437
> Project: HCatalog
> Issue Type: Bug
> Affects Versions: 0.5, 0.4.1
> Reporter: Vandana Ayyalasomayajula
> Assignee: Vandana Ayyalasomayajula
> Priority: Minor
> Attachments: HCAT-437.patch
>
>
> The equals() method in HCatSchema class uses the hashcode of the string
> obtained from toString(). The equals method should ideally compare the fields
> of the schema.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
