[
https://issues.apache.org/jira/browse/HCATALOG-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418651#comment-13418651
]
Travis Crawford commented on HCATALOG-445:
------------------------------------------
Overall looks good, but a couple comments.
* Can you update the clover target to have something like
[findbugs.xml|https://github.com/traviscrawford/hcatalog/blob/trunk/ant/findbugs.xml#L56]
that fails with a useful error message if clover is not configured correctly.
* Usage is a little weird, because the "clover" target doesn't really do
anything for the end user - it just sets up instrumentation. The actual targets
users care about don't have a "description" so they don't show up on the ant
targets list. What do you think about making "clover" setup instrumentation,
run tests, and generate the reports? Then a user can simply "ant clean clover"
to get the clover output.
I'm running these now for the first time, curious what they look like. In past
projects I've always used emma, and am curious to see the difference.
> Clover builds broken on trunk
> -----------------------------
>
> Key: HCATALOG-445
> URL: https://issues.apache.org/jira/browse/HCATALOG-445
> Project: HCatalog
> Issue Type: Bug
> Components: build
> Affects Versions: 0.4
> Reporter: Alan Gates
> Fix For: 0.5
>
> Attachments: HCATALOG-445.patch, HCATALOG-445.patch
>
>
> After the changes to split out Pig functionality into a separate jar clover
> builds fail. When it runs tests in the hcatalog-pig-adaptor directory tests
> fail with the following:
> {code}
> com_cenqua_clover/CoverageRecorder
> java.lang.NoClassDefFoundError: com_cenqua_clover/CoverageRecorder
> at
> org.apache.hcatalog.HcatTestUtils.createTestDataFile(HcatTestUtils.java:83)
> at
> org.apache.hcatalog.pig.TestHCatStorer.testDynamicPartitioningMultiPartColsInDataPartialSpec(Unknown
> Source)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
