[
https://issues.apache.org/jira/browse/HCATALOG-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418675#comment-13418675
]
Travis Crawford commented on HCATALOG-182:
------------------------------------------
A little late to the party... Started taking a look at this and its a BIG
patch. Its basically unreviewably large. My 2c is addressing only blocking
issues and getting this checked in ASAP. In the future it would we awesome to
just do development of new components in trunk so all code uses the regular
process.
Comments from before I started skimming:
*conf/templeton-log4j.properties*
* What do you think about using a sized-based log rotation config by default?
What I see in production are spammy log lines that cause disks to fill up in
less than a day. Daily is handy for developers doing debug stuff because you
can find logs quickly, but to guard against full disks the sized-based configs
are preferable.
* INFO by default?
*conf/templeton-default.xml*
Here we see some lines with version numbers. Do these accept globs? I can see
this being a source of misconfiguration where libraries are upgraded, a deploy
happens, and the config becomes outdated. The code and configs are often not
pushed out together.
{code}
<property>
<name>templeton.jar</name>
<value>${env.TEMPLETON_HOME}/templeton-0.1.0-dev.jar</value>
<description>The path to the Templeton jar file.</description>
</property>
{code}
Is there a good reason not to use HADOOP_HOME? Same with HCAT_PREFIX (why not
use HCAT_HOME)?
{code}
<property>
<name>templeton.hadoop</name>
<value>${env.HADOOP_PREFIX}/bin/hadoop</value>
<description>The path to the Hadoop executable.</description>
</property>
{code}
There are some properties that do not include units. This often leads to
misconfigurations.
{code}
<property>
<name>templeton.hdfs.cleanup.maxage</name>
<value>604800000</value>
<description>The maximum age of a templeton job</description>
</property>
{code}
> Web services interface for HCatalog access and Pig, Hive, and MR job execution
> ------------------------------------------------------------------------------
>
> Key: HCATALOG-182
> URL: https://issues.apache.org/jira/browse/HCATALOG-182
> Project: HCatalog
> Issue Type: New Feature
> Components: client
> Affects Versions: 0.5
> Reporter: Alan Gates
> Assignee: Thejas M Nair
> Fix For: 0.5
>
> Attachments: HCAT-182-2.patch, HCAT-182-3.patch, HCAT-182-4.patch,
> HCAT-182-5.patch, HCAT-182-6.patch, HCAT-182-7.patch, HCAT-templeton.patch
>
>
> This JIRA proposes a web services API to be added for HCatalog. The initial
> version will be very simple, just wrapping existing SQL commands. Eventually
> we should provide richer APIs that return nicely formated results.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
