----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6114/ -----------------------------------------------------------
(Updated July 27, 2012, 1:23 a.m.)
Review request for hcatalog and Rohini Palaniswamy.
Changes
-------
Added better cleanup.
Condition for cleanup:
1. The client shouldn't be used by any thread
2. Must be beyond expiry time
If the above conditions are met any of the following cleans up the client
1. close() being called by users
2. Item being evicted because of expiry time (this is triggered by any cache
access)
The shutdown hook takes care of the cleaning the remaining clients if any.
Description
-------
Time expiry based HiveMetaStoreClient cache for HCatalog
This addresses bug HCATALOG-370.
https://issues.apache.org/jira/browse/HCATALOG-370
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/ivy.xml
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatConf.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatUtil.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/cache/HiveClientCache.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/PigHCatUtil.java
1364830
http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/common/TestHiveClientCache.java
PRE-CREATION
Diff: https://reviews.apache.org/r/6114/diff/
Testing
-------
Thanks,
Arup Malakar
