Jira's still down, so here's the branch to get the discussion started. The ruleset basically checks for unused imports, star imports, and that files end with a newline. Its surprising to see how many unnecessary lines are removed.
https://github.com/traviscrawford/hcatalog/compare/travis_add_checkstyle --travis On Sat, Aug 11, 2012 at 10:48 AM, Travis Crawford <[email protected]> wrote: > Hey hcat gurus - > > I'd like to add checkstyle to our build, with the goal of automating > the rules we all should be following anyway, so we write better code & > reviewers don't have to focus on style nits. > > Its easy to go overboard with checkstyle – let's explicitly not do > that. However, there are some things I bet we can all agree on (stuff > like removing unused imports). > > If this sounds good, I'll post a branch I have that runs checkstyle as > part of the build process and enforces a small set of rules, but more > importantly gets this into our process so we can slowly move towards a > more consistent coding style. > > Thoughts? > > --travis
