----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6404/#review10295 -----------------------------------------------------------
ivy/libraries.properties <https://reviews.apache.org/r/6404/#comment21805> nitpick: suffix hadoop related variables with 20 or 23 same as the ivy conf (ie hadoop23-archives). shims/src/20/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java <https://reviews.apache.org/r/6404/#comment21855> shouldn't this be named HCatHadoopShims20 shims/src/20/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java <https://reviews.apache.org/r/6404/#comment21904> use the constructors instead of reflection where possible shims/src/20/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java <https://reviews.apache.org/r/6404/#comment21854> rename method to better indicate to DSL impelementors what it is used for. shims/src/20/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java <https://reviews.apache.org/r/6404/#comment21853> nitipick: wouldn't something like "JobLauncher" be less confusing? It's neither a jobtracker or rm. - Francis Liu On Aug. 6, 2012, 6:51 p.m., Chris Drome wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6404/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 6:51 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > Modifications to allow HCatalog to work with Hadoop23. > > > This addresses bug HCATALOG-375. > https://issues.apache.org/jira/browse/HCATALOG-375 > > > Diffs > ----- > > build.properties PRE-CREATION > build.xml 8398d9c > ivy.xml 910d013 > ivy/libraries.properties 539890a > shims/build.xml PRE-CREATION > shims/ivy.xml PRE-CREATION > shims/src/20/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java > PRE-CREATION > shims/src/20S/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java > aad30bc > shims/src/23/java/org/apache/hcatalog/shims/HCatHadoopShims23.java 386f8bb > src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java 26901ae > src/java/org/apache/hcatalog/data/transfer/impl/HCatInputFormatReader.java > 0911f99 > src/java/org/apache/hcatalog/data/transfer/impl/HCatOutputFormatWriter.java > 0b71632 > src/java/org/apache/hcatalog/data/transfer/state/StateProvider.java ef2adbd > src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java > 66f3f16 > src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java > 31e0076 > src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java a5b2906 > src/java/org/apache/hcatalog/mapreduce/ProgressReporter.java 1748d05 > src/java/org/apache/hcatalog/mapreduce/Security.java b0b26dc > src/java/org/apache/hcatalog/pig/HCatStorer.java b78eb76 > src/java/org/apache/hcatalog/shims/HCatHadoopShims.java 385aa03 > src/test/e2e/hcatalog/build.xml 3997d4f > src/test/e2e/hcatalog/conf/default.conf 05c29ac > src/test/e2e/hcatalog/drivers/Util.pm ca6eebc > src/test/e2e/hcatalog/tests/hcat.conf cbd5863 > src/test/e2e/hcatalog/tools/generate/generate_data.pl 8fb206d > src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/SimpleRead.java > 4680f77 > src/test/org/apache/hcatalog/HcatTestUtils.java f43200d > src/test/org/apache/hcatalog/data/TestReaderWriter.java 9eb9d4d > src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 34df0a8 > src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java > 52e3b26 > src/test/org/apache/hcatalog/mapreduce/TestSequenceFileReadWrite.java > f9d2086 > > storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java > 95e38e2 > > Diff: https://reviews.apache.org/r/6404/diff/ > > > Testing > ------- > > Passed e2e tests using Hadoop20 and Hadoop23. > > > Thanks, > > Chris Drome > >
