[
https://issues.apache.org/jira/browse/HCATALOG-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435329#comment-13435329
]
Dmitriy V. Ryaboy commented on HCATALOG-460:
--------------------------------------------
A few comments:
* comments should be in javadoc format for HCatConstants (make those props
visible in documentation)
* HCatContext should have apache headers
* the no-arg get() method could just be "return
Preconditions.checkNotNull(hcatContext)". FYI, by convention this method is
normally called getInstance(). Check out the wikipedia article for standard
approaches (and drawbacks) to building singletons:
http://en.wikipedia.org/wiki/Singleton_pattern
* a get() method that sets things is not a good idea, too much surprise. Why
overwrite confs? If I call HCatContext.get(myconf), seems like the assumption
is that hcatContext will have my conf in it -- but someone else might call
.get(hisconf) before I use the context I get back, and suddenly I get his
properties instead of mine. What's the intended behavior? Would it be better to
do something like HCatContext.getInstance().mergeConf(myconf) ?
> Enable boolean to integer conversions
> -------------------------------------
>
> Key: HCATALOG-460
> URL: https://issues.apache.org/jira/browse/HCATALOG-460
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Attachments: HCATALOG-460_boolean_to_int.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
