[ 
https://issues.apache.org/jira/browse/HCATALOG-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435570#comment-13435570
 ] 

Travis Crawford commented on HCATALOG-467:
------------------------------------------

Hey Jakob, thanks for sending a patch to fix this. A couple comments:

There's a typo in this line:

{code}
-        for dir in  "share/templeton/lib" "build/ivy/lib/templeton" "conf" ; do
+        for dir in  "share/hctalog" "build/ivy/lib/templeton" "conf" ; do
{code}

Not really your doing, but hard-coding jar versions is pretty janky. Instead of 
this stuff:

{code}
-TEMPLETON_JAR=templeton-0.1.0-dev.jar
+TEMPLETON_JAR=webhcat-0.5.0-SNAPSHOT.jar
{code}

Can you do something along the lines of this so the script doesn't need updated 
each time the version changes?

{code}
TEMPLETON_JAR=$(find ${HCAT_HOME}/share/hcatalog/webhcat-*.jar
{code}
                
> Templeton scripts point to wrong jar name
> -----------------------------------------
>
>                 Key: HCATALOG-467
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-467
>             Project: HCatalog
>          Issue Type: Bug
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>            Priority: Blocker
>         Attachments: HCAT-467.patch
>
>
> Templeton right now won't start due to referencing wrong jar and directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to