-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6856/
-----------------------------------------------------------
Review request for hcatalog, Dmitriy Ryaboy and Feng Peng.
Description
-------
HCatalog should use checkstyle to enforce coding style
This addresses bug HCATALOG-486.
https://issues.apache.org/jira/browse/HCATALOG-486
Diffs
-----
ant/checkstyle.xml PRE-CREATION
ant/deploy.xml 7e2934c
build.xml 37af4a7
coding_style.xml PRE-CREATION
hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatLoader.java
579811a
hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatStorer.java
7696587
hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/drivers/LoadFuncBasedInputFormat.java
c6ecae3
hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/drivers/StoreFuncBasedOutputFormat.java
67a4ccd
ivy.xml 0230b5c
ivy/libraries.properties 4d199f3
pom.xml PRE-CREATION
shims/src/23/java/org/apache/hcatalog/shims/HCatHadoopShims23.java e7bf16a
src/java/org/apache/hcatalog/data/DefaultHCatRecord.java 5606c54
src/java/org/apache/hcatalog/data/HCatRecord.java 9404a7d
src/java/org/apache/hcatalog/data/HCatRecordable.java 68d8d8b
src/java/org/apache/hcatalog/data/transfer/ReadEntity.java 45e01d9
src/java/org/apache/hcatalog/data/transfer/impl/HCatInputFormatReader.java
3580612
src/java/org/apache/hcatalog/data/transfer/impl/HCatOutputFormatWriter.java
c30ca36
src/java/org/apache/hcatalog/data/transfer/state/StateProvider.java 4b09a59
src/java/org/apache/hcatalog/listener/NotificationListener.java 63775f7
src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
e9f3fa3
src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java e76690f
src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java 41d458f
src/java/org/apache/hcatalog/mapreduce/PartInfo.java 235233f
src/java/org/apache/hcatalog/shims/HCatHadoopShims.java e285035
src/test/e2e/hcatalog/tools/generate/java/org/apache/hadoop/hive/tools/generate/RCFileGenerator.java
a269d44
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/DataWriterMaster.java
3dcc1ec
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/GroupByAge.java
7abaab3
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/HBaseReadWrite.java
c420233
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/HCatTestDriver.java
f32a364
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/HCatTypeCheck.java
0a279f0
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/ReadJson.java
cc1da1b
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/ReadRC.java 884fa42
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/ReadText.java
7797ce1
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/StoreDemo.java
4c97057
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/TypeDataCheck.java
16f29fb
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/WriteJson.java
55fff1d
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/WriteRC.java
83eacfc
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/WriteText.java
c7293f0
src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/WriteTextPartitioned.java
9630ccf
src/test/org/apache/hcatalog/ExitException.java 2062f2c
src/test/org/apache/hcatalog/NoExitSecurityManager.java 2cc6ff6
src/test/org/apache/hcatalog/cli/TestPermsGrp.java 5c094ac
src/test/org/apache/hcatalog/common/TestHiveClientCache.java b6241ef
src/test/org/apache/hcatalog/data/TestDefaultHCatRecord.java 250c5dc
src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java 42c9795
src/test/org/apache/hcatalog/data/schema/TestHCatSchema.java 3a72e78
src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 2509c20
src/test/org/apache/hcatalog/mapreduce/TestHCatHiveThriftCompatibility.java
0c5b982
src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java f451082
src/test/org/apache/hcatalog/mapreduce/TestPassProperties.java b55ef09
storage-handlers/hbase/build.xml 7c06e0b
storage-handlers/hbase/ivy.xml 8d1e271
storage-handlers/hbase/pom.xml PRE-CREATION
storage-handlers/hbase/src/gen-java/org/apache/hcatalog/hbase/snapshot/transaction/thrift/StoreFamilyRevision.java
a55dde7
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
5f40b42
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
be07e10
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
433f5f5
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpointClient.java
00db32b
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
02e7fc9
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKUtil.java
0e4066f
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/lock/LockListener.java
6494279
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/ManyMiniCluster.java
1c19699
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java
aa2f01b
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseHCatStorageHandler.java
e6da40b
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java
b0deb86
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManager.java
5b63c40
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerConfiguration.java
1fd8a93
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerEndpoint.java
ae93211
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestThriftSerialization.java
7414a2a
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestZNodeSetUp.java
aecd2be
webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java
91721f5
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CompleteDelegator.java
ed0e538
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/DeleteDelegator.java
5e12605
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/GroupPermissionsDesc.java
b96ef25
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/LauncherDelegator.java
bdcb1c3
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/ListDelegator.java
60eb7fa
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java
5a9861d
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/SimpleWebException.java
733bd97
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/tool/TempletonControllerJob.java
8bdb1f1
webhcat/svr/src/main/java/org/apache/hcatalog/templeton/tool/TempletonUtils.java
62930b2
webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestDesc.java d13307a
webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestServer.java
85f35f0
webhcat/svr/src/test/java/org/apache/hcatalog/templeton/tool/TestTempletonUtils.java
d034a21
webhcat/svr/src/test/java/org/apache/hcatalog/templeton/tool/TestTrivialExecService.java
9d0af61
Diff: https://reviews.apache.org/r/6856/diff/
Testing
-------
Thanks,
Travis Crawford
