----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6874/#review10946 -----------------------------------------------------------
Ship it! Ship It! - Dmitriy Ryaboy On Aug. 31, 2012, 4:37 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6874/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 4:37 p.m.) > > > Review request for hcatalog, Dmitriy Ryaboy and Feng Peng. > > > Description > ------- > > HCatalog style cleanups and readd javac debug option. > > * Readd javac debug option that was unintentionally dropped during a build > refactor change. > * Update TestReaderWriter and TestLazyHCatRecord to junit4 style. > * Rename a field in LazyHCatRecord from "o" to "wrappedObject" to improve > readability. > * Minor code reformatting. > > > This addresses bug HCATALOG-489. > https://issues.apache.org/jira/browse/HCATALOG-489 > > > Diffs > ----- > > build-common.xml ac9b4f5 > src/java/org/apache/hcatalog/common/HCatUtil.java 27adde6 > src/java/org/apache/hcatalog/data/LazyHCatRecord.java 51e9857 > src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java 7187788 > src/test/org/apache/hcatalog/data/TestReaderWriter.java c7c0b09 > > Diff: https://reviews.apache.org/r/6874/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
