----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6494/#review11671 -----------------------------------------------------------
hcatalog-pig-adapter/build.xml <https://reviews.apache.org/r/6494/#comment25212> Currently the "common" build sub projects generate a POM file from ivy.xml as part of the build. In dependencies.xml we see: http://svn.apache.org/viewvc/incubator/hcatalog/trunk/ant/dependencies.xml?view=markup <ivy:configure file="${ivysettings.xml}"/> <ivy:makepom ivyfile="${ivy.xml}" pomfile="${pom.file}"> <mapping conf="default" scope="compile"/> </ivy:makepom> And later when we publish artifacts to a Maven repo, we use this generated pom.xml. As subprojects switch to defining dependencies in pom.xml, and entirely removing ivy from the build, we won't need this generation step. So back to your original question - we need to define "pom.file" even for projects that still use ivy for their deps, because its needed to publish the artifacts. - Travis Crawford On Sept. 12, 2012, 11:47 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6494/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 11:47 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > hcatalog-server-extensions.jar is an existing artifact we provide. This > change refactors the repo layout & build so that server-extensions is a new > subproject with its own Ivy dependencies. > > The benefit is users who do not need the server extensions do not pull JMS & > other transitive dependencies into their project. > > > This addresses bug HCATALOG-461. > https://issues.apache.org/jira/browse/HCATALOG-461 > > > Diffs > ----- > > ant/deploy.xml 84c3648 > build-common.xml 8740772 > build.xml b7fc8a1 > hcatalog-pig-adapter/build.xml 8dbc319 > ivy.xml 11e45bf > server-extensions/build.xml PRE-CREATION > server-extensions/pom.xml PRE-CREATION > > server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestMsgBusConnection.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestNotificationListener.java > PRE-CREATION > src/java/org/apache/hcatalog/listener/NotificationListener.java 5c6b8ad > src/test/org/apache/hcatalog/listener/TestMsgBusConnection.java 0db2b16 > src/test/org/apache/hcatalog/listener/TestNotificationListener.java 9a66427 > webhcat/java-client/build.xml fc1386c > webhcat/svr/build.xml a7bc34c > > Diff: https://reviews.apache.org/r/6494/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
