[
https://issues.apache.org/jira/browse/HCATALOG-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495891#comment-13495891
]
Thejas M Nair commented on HCATALOG-549:
----------------------------------------
Travis, thanks for the review comments!
bq. can you post patches in reviewboard?
Created - https://reviews.apache.org/r/8033/
bq. For some reason I thought Apache releases shouldn't package 3rdparty jars.
Should we be doing the following?
That does not seem to be the case - hadoop, pig, and hive package 3rd party
jars. In case of hcatalog, since it depended on hive which includes almost
everything, it didn't need to package the jars. But looks like with my change
everything in the world including hadoop and hive is now packaged in hcat. I
will change that to include only requirements of webhcat that are not satisfied
by hadoop/hive and its dependencies. I need to see if there is a clean way to
do that.
bq. Let's continue using the name java-client in the directory, since it lets
us add different language clients in the future without changes. That was the
rationale when going with the java-client subproject directory name and we
should propagate that through to packaging too.
Makes sense, will fix the dir name
bq. At packaging time we shouldn't need to change directory structures like
follows. We should put these webhcat server config files in
webhcat/svr/src/main/config as is the maven directory layout. When creating the
final dist dir we can simply copy the directory as-is over to
dist.dir/etc/webhcat.
Thanks for the maven tips, will do that.
bq. In the renamed webhcat-default.xml we still see templeton references.
Yes, I haven't changed that in this patch. Will create another jira for that.
> rename webhcat config and shell scripts to use webhcat in the names
> -------------------------------------------------------------------
>
> Key: HCATALOG-549
> URL: https://issues.apache.org/jira/browse/HCATALOG-549
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Fix For: 0.5
>
> Attachments: HCATALOG-549.1.patch
>
>
> The shell scripts and config files used for webhcat server should be called
> webhcat* instead of templeton* .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
