[ 
https://issues.apache.org/jira/browse/HCATALOG-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497544#comment-13497544
 ] 

Travis Crawford commented on HCATALOG-518:
------------------------------------------

To preserve svn history, I generated this patch excluding the moved files. 
Below is how I generated that final patch (attached) and the svn commands I 
used to reorganize the source tree.

git diff apache/trunk --name-only | grep -v 'core/src/' | grep -v 'src/java/' | 
grep -v 'src/test' | xargs git diff --no-prefix apache/trunk -- > 
HCATALOG-518_core_submodule.3.nomovedsrc.patch

{code}
fynn-2:trunk travis$ svn mkdir --parents core/src/main
A         core
A         core/src
A         core/src/main
fynn-2:trunk travis$ svn mkdir --parents core/src/test/java
A         core/src/test
A         core/src/test/java
fynn-2:trunk travis$ svn mv src/java core/src/main/
A         core/src/main/java
D         src/java
D         src/java/org
D         src/java/org/apache
D         src/java/org/apache/hadoop
D         src/java/org/apache/hadoop/mapred
D         src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java
D         src/java/org/apache/hcatalog
D         src/java/org/apache/hcatalog/cli
D         src/java/org/apache/hcatalog/cli/HCatCli.java
D         src/java/org/apache/hcatalog/cli/HCatDriver.java
D         src/java/org/apache/hcatalog/cli/SemanticAnalysis
D         
src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java
D         src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
D         
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
D         
src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
D         src/java/org/apache/hcatalog/common
D         src/java/org/apache/hcatalog/common/ErrorType.java
D         src/java/org/apache/hcatalog/common/HCatConstants.java
D         src/java/org/apache/hcatalog/common/HCatContext.java
D         src/java/org/apache/hcatalog/common/HCatException.java
D         src/java/org/apache/hcatalog/common/HCatUtil.java
D         src/java/org/apache/hcatalog/common/HiveClientCache.java
D         src/java/org/apache/hcatalog/data
D         src/java/org/apache/hcatalog/data/DataType.java
D         src/java/org/apache/hcatalog/data/DefaultHCatRecord.java
D         src/java/org/apache/hcatalog/data/HCatRecord.java
D         src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
D         
src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
D         src/java/org/apache/hcatalog/data/HCatRecordSerDe.java
D         src/java/org/apache/hcatalog/data/HCatRecordable.java
D         src/java/org/apache/hcatalog/data/JsonSerDe.java
D         src/java/org/apache/hcatalog/data/LazyHCatRecord.java
D         src/java/org/apache/hcatalog/data/Pair.java
D         src/java/org/apache/hcatalog/data/ReaderWriter.java
D         src/java/org/apache/hcatalog/data/schema
D         src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java
D         src/java/org/apache/hcatalog/data/schema/HCatSchema.java
D         src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java
D         src/java/org/apache/hcatalog/data/transfer
D         src/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java
D         src/java/org/apache/hcatalog/data/transfer/EntityBase.java
D         src/java/org/apache/hcatalog/data/transfer/HCatReader.java
D         src/java/org/apache/hcatalog/data/transfer/HCatWriter.java
D         src/java/org/apache/hcatalog/data/transfer/ReadEntity.java
D         src/java/org/apache/hcatalog/data/transfer/ReaderContext.java
D         src/java/org/apache/hcatalog/data/transfer/WriteEntity.java
D         src/java/org/apache/hcatalog/data/transfer/WriterContext.java
D         src/java/org/apache/hcatalog/data/transfer/impl
D         
src/java/org/apache/hcatalog/data/transfer/impl/HCatInputFormatReader.java
D         
src/java/org/apache/hcatalog/data/transfer/impl/HCatOutputFormatWriter.java
D         src/java/org/apache/hcatalog/data/transfer/state
D         
src/java/org/apache/hcatalog/data/transfer/state/DefaultStateProvider.java
D         src/java/org/apache/hcatalog/data/transfer/state/StateProvider.java
D         src/java/org/apache/hcatalog/har
D         src/java/org/apache/hcatalog/har/HarOutputCommitterPostProcessor.java
D         src/java/org/apache/hcatalog/listener
D         src/java/org/apache/hcatalog/mapred
D         src/java/org/apache/hcatalog/mapreduce
D         
src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
D         
src/java/org/apache/hcatalog/mapreduce/DefaultOutputFormatContainer.java
D         
src/java/org/apache/hcatalog/mapreduce/DefaultRecordWriterContainer.java
D         
src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
D         src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
D         src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
D         src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
D         src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
D         src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java
D         src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java.broken
D         
src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java.broken
D         
src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java.broken
D         src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java
D         src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
D         src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
D         src/java/org/apache/hcatalog/mapreduce/HCatSplit.java
D         src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java
D         src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java
D         src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
D         src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
D         src/java/org/apache/hcatalog/mapreduce/InternalUtil.java
D         src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java
D         src/java/org/apache/hcatalog/mapreduce/OutputCommitterContainer.java
D         src/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java
D         src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java
D         src/java/org/apache/hcatalog/mapreduce/PartInfo.java
D         src/java/org/apache/hcatalog/mapreduce/ProgressReporter.java
D         src/java/org/apache/hcatalog/mapreduce/RecordWriterContainer.java
D         src/java/org/apache/hcatalog/mapreduce/Security.java
D         src/java/org/apache/hcatalog/mapreduce/StorerInfo.java
D         src/java/org/apache/hcatalog/metadata
D         src/java/org/apache/hcatalog/oozie
D         src/java/org/apache/hcatalog/oozie/JavaAction.java
D         src/java/org/apache/hcatalog/rcfile
D         src/java/org/apache/hcatalog/rcfile/RCFileMapReduceInputFormat.java
D         src/java/org/apache/hcatalog/rcfile/RCFileMapReduceOutputFormat.java
D         src/java/org/apache/hcatalog/rcfile/RCFileMapReduceRecordReader.java
D         src/java/org/apache/hcatalog/security
D         src/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java
D         
src/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
D         src/java/org/apache/hcatalog/shims
D         src/java/org/apache/hcatalog/shims/HCatHadoopShims.java
D         src/java/org/apache/hcatalog/storagehandler
D         src/java/org/apache/hcatalog/storagehandler/DummyHCatAuthProvider.java
fynn-2:trunk travis$ svn mv src/test/org core/src/test/java/
A         core/src/test/java/org
D         src/test/org
D         src/test/org/apache
D         src/test/org/apache/hcatalog
D         src/test/org/apache/hcatalog/ExitException.java
D         src/test/org/apache/hcatalog/HcatTestUtils.java
D         src/test/org/apache/hcatalog/MiniCluster.java
D         src/test/org/apache/hcatalog/NoExitSecurityManager.java
D         src/test/org/apache/hcatalog/cli
D         src/test/org/apache/hcatalog/cli/DummyStorageHandler.java
D         src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java.broken
D         src/test/org/apache/hcatalog/cli/TestPermsGrp.java
D         src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java
D         
src/test/org/apache/hcatalog/cli/TestStorageHandlerProperties.java.broken
D         src/test/org/apache/hcatalog/cli/TestUseDatabase.java
D         src/test/org/apache/hcatalog/common
D         src/test/org/apache/hcatalog/common/TestHCatUtil.java
D         src/test/org/apache/hcatalog/common/TestHiveClientCache.java
D         src/test/org/apache/hcatalog/data
D         src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java
D         src/test/org/apache/hcatalog/data/TestDefaultHCatRecord.java
D         src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
D         src/test/org/apache/hcatalog/data/TestJsonSerDe.java
D         src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java
D         src/test/org/apache/hcatalog/data/TestReaderWriter.java
D         src/test/org/apache/hcatalog/data/schema
D         src/test/org/apache/hcatalog/data/schema/TestHCatSchema.java
D         src/test/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java
D         src/test/org/apache/hcatalog/listener
D         src/test/org/apache/hcatalog/mapred
D         
src/test/org/apache/hcatalog/mapred/TestHiveHCatInputFormat.java.broken
D         src/test/org/apache/hcatalog/mapreduce
D         src/test/org/apache/hcatalog/mapreduce/HCatBaseTest.java
D         src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
D         
src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java.broken
D         
src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java.broken
D         src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java
D         
src/test/org/apache/hcatalog/mapreduce/TestHCatHiveThriftCompatibility.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatInputFormat.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatNonPartitioned.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatPartitionPublish.java
D         src/test/org/apache/hcatalog/mapreduce/TestHCatPartitioned.java
D         src/test/org/apache/hcatalog/mapreduce/TestMultiOutputFormat.java
D         src/test/org/apache/hcatalog/mapreduce/TestPassProperties.java
D         src/test/org/apache/hcatalog/mapreduce/TestSequenceFileReadWrite.java
D         src/test/org/apache/hcatalog/rcfile
D         
src/test/org/apache/hcatalog/rcfile/TestRCFileInputStorageDriver.java.broken
D         
src/test/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java
D         
src/test/org/apache/hcatalog/rcfile/TestRCFileOutputStorageDriver.java.broken
D         src/test/org/apache/hcatalog/security
D         
src/test/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java
fynn-2:trunk travis$ patch -p0 < 
~/src/hcatalog/HCATALOG-518_core_submodule.3.nomovedsrc.patch 
patching file .gitignore
patching file ant/checkstyle.xml
patching file ant/dependencies.xml
patching file ant/deploy.xml
patching file build-common.xml
patching file build.properties
patching file build.xml
patching file core/build.xml
patching file core/pom.xml
patching file hcatalog-pig-adapter/build.xml
patching file hcatalog-pig-adapter/pom.xml
patching file ivy.xml
patching file ivy/ivysettings.xml
patching file ivy/libraries.properties
patching file pom.xml
patching file server-extensions/build.xml
patching file server-extensions/pom.xml
patching file shims/build.xml
patching file shims/ivy.xml
patching file storage-handlers/build.xml
patching file storage-handlers/hbase/build.xml
patching file storage-handlers/hbase/pom.xml
patching file webhcat/java-client/build.xml
patching file webhcat/java-client/pom.xml
patching file webhcat/svr/build.xml
patching file webhcat/svr/pom.xml
fynn-2:trunk travis$
{code}
                
> Refactor hcatalog-core as subproject
> ------------------------------------
>
>                 Key: HCATALOG-518
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-518
>             Project: HCatalog
>          Issue Type: Improvement
>          Components: build
>            Reporter: Travis Crawford
>            Assignee: Travis Crawford
>         Attachments: HCAT-518-rebased_francis.patch, 
> HCATALOG-518_core_submodule.1.patch, HCATALOG-518_core_submodule.2.patch, 
> HCATALOG-518_core_submodule.3.nomovedsrc.patch
>
>
> In HCATALOG-132 and its linked issues we made a number of build changes, 
> breaking apart the monolithic HCatalog source tree into a number of 
> subprojects. The goal was publishing separate artifacts for components that 
> pull in large dependencies. For example, only the pig adapter should depend 
> on pig, only the server extensions should depend on jms, etc.
> The last major change is refactoring the "core" code into a subproject. This 
> will allow us to use the new build-common.xml system everywhere and have well 
> defined lines between the components.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to