----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7584/ -----------------------------------------------------------
(Updated Nov. 21, 2012, 1:12 a.m.) Review request for hcatalog. Changes ------- Rebased per https://issues.apache.org/jira/browse/HCATALOG-518 changes. "git merge" reported no conflicts, and the patch looks basically the same. Description ------- [HCatContext|https://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/common/HCatContext.java] is a container for a configuration that is globally accessible both on the FE & BE. Its purpose is to simplify enabling optional functionality. When I originally added this class I didn't use an enum, not knowing its the recommended way of doing singletons in java. Since we haven't make a release with this class I think we should change it now to the "Right Way" before it gets much use. I also added annotations showing the intended audience, and added some pretty good javadocs. This addresses bug HCATALOG-531. https://issues.apache.org/jira/browse/HCATALOG-531 Diffs (updated) ----- core/src/main/java/org/apache/hcatalog/common/HCatContext.java 1c40b5e core/src/main/java/org/apache/hcatalog/data/HCatRecordSerDe.java 468a1f5 core/src/main/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java b4060e9 hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatLoader.java 4bdb7c3 hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatStorer.java 54c174b Diff: https://reviews.apache.org/r/7584/diff/ Testing ------- https://travis.ci.cloudbees.com/job/HCATALOG-531_hcatcontext_enum/1/ Thanks, Travis Crawford
