> On Nov. 22, 2012, 7:16 p.m., Daniel Dai wrote: > > >> Note this adds a required -Dmvn.profile ant option. Do you think we > > >> should have a default? > > Yes, it would be better to have a default mvn.profile set to hadoop20. > > > > With this patch, I can compile HCatalog with hadoop 23. Do we also target > > running unit tests with hadoop23 in this Jira? > > Francis Liu wrote: > +1 on having a default. > > We can't run unit tests on 23 until we fix antlr and have 0.23 pig jar > published in maven.
Sounds good, I just updated my branch to default to hadoop20. Re: tests with 23, I've noticed there's a lot of confusion about what exactly should be supported. My goal of the test.sh script is to centralize our knowledge about what the right test commands to run are, so we're all on the same page. - Travis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8095/#review13693 ----------------------------------------------------------- On Nov. 16, 2012, 9:46 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8095/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 9:46 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > Add hadoop 23 build support to HCatalog through maven profiles. > > A new ./build-support/scripts/test.sh script has been added where we can put > the command we want people to run when testing, so we're all on the same page. > > Note this adds a required -Dmvn.profile ant option. Do you think we should > have a default? > > > This addresses bug HCATALOG-542. > https://issues.apache.org/jira/browse/HCATALOG-542 > > > Diffs > ----- > > ant/deploy.xml e0f5ea3 > build-common.xml 0e0af1c > build-support/scripts/test.sh PRE-CREATION > build.properties d75f5de > build.xml 61ff391 > core/pom.xml d6e2358 > hcatalog-pig-adapter/pom.xml 04d28b7 > pom.xml 6ade4a6 > server-extensions/pom.xml eaac449 > storage-handlers/hbase/pom.xml 6066b4b > webhcat/java-client/pom.xml 882abd7 > webhcat/svr/pom.xml 3ae03e7 > > Diff: https://reviews.apache.org/r/8095/diff/ > > > Testing > ------- > > Ran ./build-support/scripts/test.sh locally and at > https://travis.ci.cloudbees.com/job/travis_mvn_profiles/ > > > Thanks, > > Travis Crawford > >
