[ 
https://issues.apache.org/jira/browse/HCATALOG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575036#comment-13575036
 ] 

Travis Crawford commented on HCATALOG-616:
------------------------------------------

I agree counters would be useful here.

Re: logging, the intention here is to log some examples for debugging up to 
when the error threshold has filled up. The program should throw an exception 
for crossing the bad records threshold long before the local disk fills up from 
logging. For people that have a high bad record threshold I don't see any issue 
with placing a limit on the number of bad records to some configurable number.
                
> HCatRecordReader.InputErrorTracker should increment counters
> ------------------------------------------------------------
>
>                 Key: HCATALOG-616
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-616
>             Project: HCatalog
>          Issue Type: Bug
>            Reporter: Bill Graham
>
> It would be convenient if this class incremented counters to indicate good 
> and bad records found.
> Also logging a warning for ever bad record seems risky w.r.t. excessive logs 
> potentially filling up local disk. The frequency of the log messages should 
> be configurable. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to