Gopal V created HCATALOG-646:
--------------------------------

             Summary: HCatalog checkstyle tests breaks hive test on e2e *.res 
files
                 Key: HCATALOG-646
                 URL: https://issues.apache.org/jira/browse/HCATALOG-646
             Project: HCatalog
          Issue Type: Bug
            Reporter: Gopal V
            Priority: Trivial


ant test dies on checkstyle calls

{code}
$ ANT_OPTS="-Xms768m -Xmx1024m -XX:PermSize=128m -XX:MaxPermSize=128m" ant test 
-Dmodule=hcatalog -Dtestcase=TestCliDriver
...
[checkstyle] Running Checkstyle 5.5 on 413 files
[checkstyle] 
/home/gopal/hw/hive-apache/hcatalog/src/test/e2e/hcatalog/resource/default.res:1:
 Missing a header - not enough lines in file.
[checkstyle] 
/home/gopal/hw/hive-apache/hcatalog/src/test/e2e/hcatalog/resource/windows.res:1:
 Missing a header - not enough lines in file.
      [for] hcatalog: The following error occurred while executing this line:
      [for] /home/gopal/hw/hive-apache/build.xml:310: The following error 
occurred while executing this line:
      [for] /home/gopal/hw/hive-apache/hcatalog/build.xml:109: The following 
error occurred while executing this line:
      [for] 
/home/gopal/hw/hive-apache/hcatalog/build-support/ant/checkstyle.xml:32: Got 2 
errors and 0 warnings.
{code}

The quick and dirty fix would be to exclude these two 3 line files from the 
apache license header check

{code}
diff --git hcatalog/build-support/ant/checkstyle.xml 
hcatalog/build-support/ant/checkstyle.xml
index 84e8c39..980c7f6 100644
--- hcatalog/build-support/ant/checkstyle.xml
+++ hcatalog/build-support/ant/checkstyle.xml
@@ -53,6 +53,7 @@
           <exclude name="README.txt"/>
           <exclude name="RELEASE_NOTES.txt"/>
           <exclude name="*.patch"/>
+          <exclude name="**/*.res"/>
           <exclude name="tags"/>
           <exclude name="**/*.swp"/> <!-- vim swap files -->
           <exclude name="**/*.orig"/> <!-- files created by patch -->
{code}

Or if that is not the intention, adding the headers would also fix the build.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to