Hi Rob, Thanks! I'll try to get a look at this over the weekend so I can get it into 1.10.0. I changed the #ifdefs around so that MinGW would do better at picking up the Windows functions. I looks like I was off by a bit :/
The revise_chunks branch (a staging branch for 1.10.0 changes) has updated test files that are wrapped in #ifdefs. https://svn.hdfgroup.uiuc.edu/hdf5/branches/revise_chunks Can you copy the pertinent files from there into your 1.10.0 distribution and let me know if they build ok and don't interfere with the tests? test_usecases.sh should pass and the output should indicate that it was skipped. The changed files are: M /branches/revise_chunks/test/atomic_reader.c M /branches/revise_chunks/test/atomic_writer.c M /branches/revise_chunks/test/test_usecases.sh.in M /branches/revise_chunks/test/twriteorder.c M /branches/revise_chunks/test/use.h M /branches/revise_chunks/test/use_append_chunk.c M /branches/revise_chunks/test/use_append_mchunks.c M /branches/revise_chunks/test/use_common.c M /branches/revise_chunks/test/use_disable_mdc_flushes.c Cheers, Dana -----Original Message----- From: Hdf-forum [mailto:[email protected]] On Behalf Of [email protected] Sent: Friday, March 25, 2016 7:45 PM To: HDF Users Discussion List <[email protected]> Subject: Re: [Hdf-forum] Release of HDF5-1.10.0-pre2 -----Original Message----- From: Dana Robinson Sent: Saturday, March 26, 2016 12:34 AM To: HDF Users Discussion List Subject: Re: [Hdf-forum] Release of HDF5-1.10.0-pre2 > Hi Rob, > > - I'm not sure what to make of the timezone struct. Can you send me > the src/H5pubconf.h that is generated by configure and your configure output? > I'd like to see what MinGW thinks you have. > Attached (in relation to the pre2 build). I notice that from pre1 to pre2 , the line "#endif /* H5_HAVE_VISUAL_STUDIO */" in H5win32defs.h was raised a few lines higher, thereby exposing my build to the redefinition of "struct timezone". (There was no issue with "struct timezone" in pre1.) I'm also attaching a diff of the H5pubconf.h between pre1 and pre2. - as I'm not sure that all of those changes are correct. (Haven't yet detected any problems with them, however.) The configure command (as copy'n'pasted from config.log) was: $ ./configure --disable-shared --enable-static CFLAGS=-DH5_HAVE_WIN32_API CPPFLAGS=-IC:/_32/msys_492/1.0/local/include LDFLAGS=-LC:/_32/msys_492/1.0/local/lib --prefix=C:/_32/msys_492/1.0/local > > - Those problematic files in tests were designed for POSIX and assume the > presence of fork(), pid_t, etc. Since they are only built by the > autotools, our testing suite never flagged a problem since we only support > Windows under CMake and don't support MinGW. In the grand scheme of > things, they aren't important. The atomic writer and reader programs are > for testing new file systems for SWMR and the others are programs that are > invoked by a shell script that tests a few SWMR use cases. I'll try to > have a MinGW bypass for the 1.10.0 release for all of them. > I think that would be fine by me. Thanks, Dana. Cheers, Rob _______________________________________________ Hdf-forum is for HDF software users discussion. [email protected] http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org Twitter: https://twitter.com/hdf5
