Hello!

As a side effect, I'd like to propose the attached (cosmetic) patches for HDF5 CMake config.

Back to the initial problem, somehow
build-VS2013-32.bat
from
CMake-hdf5-1.10.1.zip
works for me. I cannot understand the difference between
build-VS2013-32.bat
method and direct cmake calls with
-DHDF5_ALLOW_EXTERNAL_SUPPORT=TGZ
and
-DTGZPATH

:-(

Best wishes,
Andrey Paramonov

25.07.2017 19:32, Андрей Парамонов пишет:
Hello!

I need to build HDF5 with thread safety.
Previously the following command (followed by cmake --build .) worked perfectly:

cmake -G "Visual Studio 12" -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DHDF5_ALLOW_EXTERNAL_SUPPORT=SVN -DZLIB_SVN_URL=http://svn.hdfgroup.uiuc.edu/zlib/trunk -DHDF5_ENABLE_THREADSAFE=ON ../hdf5-1.8.19

Now that http://svn.hdfgroup.uiuc.edu/zlib/trunk is no more available, I'm trying:

cmake -G "Visual Studio 12" -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DHDF5_ALLOW_EXTERNAL_SUPPORT=TGZ -DTGZPATH=. -DHDF5_ENABLE_THREADSAFE=ON -DHDF5_BUILD_CPP_LIB=OFF -DHDF5_BUILD_HL_LIB=OFF ../hdf5-1.10.1

(ZLib.tar.gz is in the build dir)

But I get
"hdf5-1.10.1-build\ALL_BUILD.vcxproj" (целевой объект по умолчанию) (1) ->
"hdf5-1.10.1-build\ZLIB.vcxproj" (целевой объект по умолчанию) (7) ->
(Целевой объект CustomBuild) ->
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(170,5): error MSB6006: "cmd.exe" завершилась с кодом 1. [E:\hdf5-1.10.1-build\ZLIB.vcxproj]

How to properly use
-DHDF5_ALLOW_EXTERNAL_SUPPORT=TGZ
???

Best wishes,
Andrey Paramonov



--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

--- orig/CMakeFilters.cmake     2017-04-26 00:45:01.000000000 +0300
+++ CMakeFilters.cmake  2017-07-25 18:18:10.860165600 +0300
@@ -12,9 +12,9 @@
 
 include (ExternalProject)
 #option (HDF5_ALLOW_EXTERNAL_SUPPORT "Allow External Library Building (NO GIT 
SVN TGZ)" "NO")
-set (HDF5_ALLOW_EXTERNAL_SUPPORT "NO" CACHE STRING "Allow External Library 
Building (NO SVN TGZ)")
+set (HDF5_ALLOW_EXTERNAL_SUPPORT "NO" CACHE STRING "Allow External Library 
Building (NO GIT SVN TGZ)")
 set_property (CACHE HDF5_ALLOW_EXTERNAL_SUPPORT PROPERTY STRINGS NO GIT SVN 
TGZ)
-if (HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "GIT" OR HDF5_ALLOW_EXTERNAL_SUPPORT 
MATCHES "SVN" OR HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "TGZ")
+if (NOT HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "NO")
   option (ZLIB_USE_EXTERNAL "Use External Library Building for ZLIB" 1)
   option (SZIP_USE_EXTERNAL "Use External Library Building for SZIP" 1)
   if (HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "GIT")
@@ -61,7 +61,7 @@
       set (ZLIB_INCLUDE_DIR_GEN ${ZLIB_INCLUDE_DIR})
       set (ZLIB_INCLUDE_DIRS ${ZLIB_INCLUDE_DIRS} ${ZLIB_INCLUDE_DIR})
     else ()
-      if (HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "GIT" OR 
HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "SVN" OR HDF5_ALLOW_EXTERNAL_SUPPORT 
MATCHES "TGZ")
+      if (NOT HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "NO")
         EXTERNAL_ZLIB_LIBRARY (${HDF5_ALLOW_EXTERNAL_SUPPORT})
         set (H5_HAVE_FILTER_DEFLATE 1)
         set (H5_HAVE_ZLIB_H 1)
@@ -111,7 +111,7 @@
     set (SZIP_INCLUDE_DIR_GEN ${SZIP_INCLUDE_DIR})
     set (SZIP_INCLUDE_DIRS ${SZIP_INCLUDE_DIRS} ${SZIP_INCLUDE_DIR})
   else ()
-    if (HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "GIT" OR 
HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "SVN" OR HDF5_ALLOW_EXTERNAL_SUPPORT 
MATCHES "TGZ")
+    if (NOT HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "NO")
       EXTERNAL_SZIP_LIBRARY (${HDF5_ALLOW_EXTERNAL_SUPPORT} 
${HDF5_ENABLE_SZIP_ENCODING})
       set (H5_HAVE_FILTER_SZIP 1)
       set (H5_HAVE_SZLIB_H 1)
--- orig/CMakeLists.txt 2017-04-13 20:26:10.000000000 +0300
+++ CMakeLists.txt      2017-07-25 17:15:48.878230300 +0300
@@ -753,7 +753,7 @@
 #-----------------------------------------------------------------------------
 add_subdirectory (${HDF5_SOURCE_DIR}/src ${PROJECT_BINARY_DIR}/src)
 
-if (HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "SVN" OR HDF5_ALLOW_EXTERNAL_SUPPORT 
MATCHES "GIT" OR HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "TGZ")
+if (NOT HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "NO")
   if (ZLIB_FOUND AND ZLIB_USE_EXTERNAL)
     ADD_DEPENDENCIES (${HDF5_LIB_TARGET} ZLIB)
     if (BUILD_SHARED_LIBS)
_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@lists.hdfgroup.org
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5

Reply via email to