Author: szetszwo
Date: Sat Oct 29 00:19:21 2011
New Revision: 1190708
URL: http://svn.apache.org/viewvc?rev=1190708&view=rev
Log:
HDFS-2436. Change FSNamesystem.setTimes(..) for allowing setting times on
directories. Contributed by Uma Maheswara Rao G
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1190708&r1=1190707&r2=1190708&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Sat Oct 29
00:19:21 2011
@@ -831,6 +831,9 @@ Release 0.23.0 - Unreleased
HDFS-2509. Add a test for DistributedFileSystem.getFileChecksum(..) on
directories or non existing files. (Uma Maheswara Rao G via szetszwo)
+ HDFS-2436. Change FSNamesystem.setTimes(..) for allowing setting times on
+ directories. (Uma Maheswara Rao G via szetszwo)
+
OPTIMIZATIONS
HDFS-1458. Improve checkpoint performance by avoiding unnecessary image
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java?rev=1190708&r1=1190707&r2=1190708&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Sat Oct 29 00:19:21 2011
@@ -1225,13 +1225,21 @@ public class FSDirectory implements Clos
* Get {@link INode} associated with the file.
*/
INodeFile getFileINode(String src) throws UnresolvedLinkException {
+ INode inode = getINode(src);
+ if (inode == null || inode.isDirectory())
+ return null;
+ assert !inode.isLink();
+ return (INodeFile) inode;
+ }
+
+ /**
+ * Get {@link INode} associated with the file / directory.
+ */
+ INode getINode(String src) throws UnresolvedLinkException {
readLock();
try {
- INode inode = rootDir.getNode(src, true);
- if (inode == null || inode.isDirectory())
- return null;
- assert !inode.isLink();
- return (INodeFile)inode;
+ INode iNode = rootDir.getNode(src, true);
+ return iNode;
} finally {
readUnlock();
}
@@ -1966,9 +1974,9 @@ public class FSDirectory implements Clos
}
/**
- * Sets the access time on the file. Logs it in the transaction log.
+ * Sets the access time on the file/directory. Logs it in the transaction
log.
*/
- void setTimes(String src, INodeFile inode, long mtime, long atime, boolean
force) {
+ void setTimes(String src, INode inode, long mtime, long atime, boolean
force) {
boolean status = false;
writeLock();
try {
@@ -1984,11 +1992,11 @@ public class FSDirectory implements Clos
boolean unprotectedSetTimes(String src, long mtime, long atime, boolean
force)
throws UnresolvedLinkException {
assert hasWriteLock();
- INodeFile inode = getFileINode(src);
+ INode inode = getINode(src);
return unprotectedSetTimes(src, inode, mtime, atime, force);
}
- private boolean unprotectedSetTimes(String src, INodeFile inode, long mtime,
+ private boolean unprotectedSetTimes(String src, INode inode, long mtime,
long atime, boolean force) {
assert hasWriteLock();
boolean status = false;
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?rev=1190708&r1=1190707&r2=1190708&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
Sat Oct 29 00:19:21 2011
@@ -967,7 +967,7 @@ public class FSNamesystem implements Nam
if (isPermissionEnabled) {
checkPathAccess(src, FsAction.WRITE);
}
- INodeFile inode = dir.getFileINode(src);
+ INode inode = dir.getINode(src);
if (inode != null) {
dir.setTimes(src, inode, mtime, atime, true);
if (auditLog.isInfoEnabled() && isExternalInvocation()) {
@@ -977,7 +977,7 @@ public class FSNamesystem implements Nam
"setTimes", src, null, stat);
}
} else {
- throw new FileNotFoundException("File " + src + " does not exist.");
+ throw new FileNotFoundException("File/Directory " + src + " does not
exist.");
}
} finally {
writeUnlock();
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java?rev=1190708&r1=1190707&r2=1190708&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
Sat Oct 29 00:19:21 2011
@@ -304,7 +304,6 @@ public abstract class INode implements C
* Always set the last modification time of inode.
*/
void setModificationTimeForce(long modtime) {
- assert !isDirectory();
this.modificationTime = modtime;
}
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java?rev=1190708&r1=1190707&r2=1190708&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
Sat Oct 29 00:19:21 2011
@@ -158,6 +158,24 @@ public class TestSetTimes extends TestCa
assertTrue(atime2 == stat.getAccessTime());
assertTrue(mtime2 == mtime3);
+ long mtime4 = System.currentTimeMillis() - (3600L * 1000L);
+ long atime4 = System.currentTimeMillis();
+ fileSys.setTimes(dir1, mtime4, atime4);
+ // check new modification time on file
+ stat = fileSys.getFileStatus(dir1);
+ assertTrue("Not matching the modification times", mtime4 == stat
+ .getModificationTime());
+ assertTrue("Not matching the access times", atime4 == stat
+ .getAccessTime());
+
+ Path nonExistingDir = new Path(dir1, "/nonExistingDir/");
+ try {
+ fileSys.setTimes(nonExistingDir, mtime4, atime4);
+ fail("Expecting FileNotFoundException");
+ } catch (FileNotFoundException e) {
+ assertTrue(e.getMessage().contains(
+ "File/Directory " + nonExistingDir.toString() + " does not
exist."));
+ }
// shutdown cluster and restart
cluster.shutdown();
try {Thread.sleep(2*MAX_IDLE_TIME);} catch (InterruptedException e) {}
