Author: atm
Date: Fri Mar 2 01:37:02 2012
New Revision: 1296019
URL: http://svn.apache.org/viewvc?rev=1296019&view=rev
Log:
HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd
Lipcon.
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1296019&r1=1296018&r2=1296019&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Fri Mar 2
01:37:02 2012
@@ -261,6 +261,8 @@ Release 0.23.3 - UNRELEASED
HDFS-3020. Fix editlog to automatically sync when buffer is full. (todd)
+ HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. (todd via atm)
+
Release 0.23.2 - UNRELEASED
INCOMPATIBLE CHANGES
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml?rev=1296019&r1=1296018&r2=1296019&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
Fri Mar 2 01:37:02 2012
@@ -247,4 +247,13 @@
<Method name="save" />
<Bug pattern="OS_OPEN_STREAM" />
</Match>
+ <!--
+ the 'metrics' member is sometimes used from synchronized blocks,
sometimes not,
+ but it's only reset by test cases, so should be fine
+ -->
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.server.namenode.FSEditLog" />
+ <Field name="metrics" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
</FindBugsFilter>
