Author: szetszwo
Date: Fri May 4 20:16:23 2012
New Revision: 1334156
URL: http://svn.apache.org/viewvc?rev=1334156&view=rev
Log:
HDFS-3303. Remove Writable implementation from RemoteEditLogManifest.
Contributed by Brandon Li
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1334156&r1=1334155&r2=1334156&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Fri May 4
20:16:23 2012
@@ -419,6 +419,9 @@ Release 2.0.0 - UNRELEASED
HDFS-3339. Change INode to package private. (John George via szetszwo)
+ HDFS-3303. Remove Writable implementation from RemoteEditLogManifest.
+ (Brandon Li via szetszwo)
+
OPTIMIZATIONS
HDFS-3024. Improve performance of stringification in addStoredBlock (todd)
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java?rev=1334156&r1=1334155&r2=1334156&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
Fri May 4 20:16:23 2012
@@ -17,22 +17,16 @@
*/
package org.apache.hadoop.hdfs.server.protocol;
-import java.io.DataInput;
-import java.io.DataOutput;
-import java.io.IOException;
import java.util.Collections;
import java.util.List;
-import org.apache.hadoop.io.Writable;
-
import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
-import com.google.common.collect.Lists;
/**
* An enumeration of logs available on a remote NameNode.
*/
-public class RemoteEditLogManifest implements Writable {
+public class RemoteEditLogManifest {
private List<RemoteEditLog> logs;
@@ -75,25 +69,4 @@ public class RemoteEditLogManifest imple
public String toString() {
return "[" + Joiner.on(", ").join(logs) + "]";
}
-
-
- @Override
- public void write(DataOutput out) throws IOException {
- out.writeInt(logs.size());
- for (RemoteEditLog log : logs) {
- log.write(out);
- }
- }
-
- @Override
- public void readFields(DataInput in) throws IOException {
- int numLogs = in.readInt();
- logs = Lists.newArrayList();
- for (int i = 0; i < numLogs; i++) {
- RemoteEditLog log = new RemoteEditLog();
- log.readFields(in);
- logs.add(log);
- }
- checkState();
- }
}