Author: eli
Date: Wed Oct 17 21:34:48 2012
New Revision: 1399443
URL: http://svn.apache.org/viewvc?rev=1399443&view=rev
Log:
HDFS-4068. DatanodeID and DatanodeInfo member should be private. Contributed by
Eli Collins
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1399443&r1=1399442&r2=1399443&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Wed Oct 17
21:34:48 2012
@@ -396,6 +396,8 @@ Release 2.0.3-alpha - Unreleased
HDFS-4029. GenerationStamp should use an AtomicLong. (eli)
+ HDFS-4068. DatanodeID and DatanodeInfo member should be private. (eli)
+
OPTIMIZATIONS
BUG FIXES
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java?rev=1399443&r1=1399442&r2=1399443&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
Wed Oct 17 21:34:48 2012
@@ -37,12 +37,12 @@ import org.apache.hadoop.classification.
public class DatanodeID implements Comparable<DatanodeID> {
public static final DatanodeID[] EMPTY_ARRAY = {};
- protected String ipAddr; // IP address
- protected String hostName; // hostname
- protected String storageID; // unique per cluster storageID
- protected int xferPort; // data streaming port
- protected int infoPort; // info server port
- protected int ipcPort; // IPC server port
+ private String ipAddr; // IP address
+ private String hostName; // hostname
+ private String storageID; // unique per cluster storageID
+ private int xferPort; // data streaming port
+ private int infoPort; // info server port
+ private int ipcPort; // IPC server port
public DatanodeID(DatanodeID from) {
this(from.getIpAddr(),
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java?rev=1399443&r1=1399442&r2=1399443&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
Wed Oct 17 21:34:48 2012
@@ -37,13 +37,13 @@ import org.apache.hadoop.util.Time;
@InterfaceAudience.Private
@InterfaceStability.Evolving
public class DatanodeInfo extends DatanodeID implements Node {
- protected long capacity;
- protected long dfsUsed;
- protected long remaining;
- protected long blockPoolUsed;
- protected long lastUpdate;
- protected int xceiverCount;
- protected String location = NetworkTopology.DEFAULT_RACK;
+ private long capacity;
+ private long dfsUsed;
+ private long remaining;
+ private long blockPoolUsed;
+ private long lastUpdate;
+ private int xceiverCount;
+ private String location = NetworkTopology.DEFAULT_RACK;
// Datanode administrative states
public enum AdminStates {
@@ -81,8 +81,7 @@ public class DatanodeInfo extends Datano
this.lastUpdate = from.getLastUpdate();
this.xceiverCount = from.getXceiverCount();
this.location = from.getNetworkLocation();
- this.adminState = from.adminState;
- this.hostName = from.hostName;
+ this.adminState = from.getAdminState();
}
public DatanodeInfo(DatanodeID nodeID) {
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java?rev=1399443&r1=1399442&r2=1399443&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
Wed Oct 17 21:34:48 2012
@@ -276,11 +276,11 @@ public class DatanodeDescriptor extends
}
public void resetBlocks() {
- this.capacity = 0;
- this.remaining = 0;
- this.blockPoolUsed = 0;
- this.dfsUsed = 0;
- this.xceiverCount = 0;
+ setCapacity(0);
+ setRemaining(0);
+ setBlockPoolUsed(0);
+ setDfsUsed(0);
+ setXceiverCount(0);
this.blockList = null;
this.invalidateBlocks.clear();
this.volumeFailures = 0;
@@ -303,15 +303,15 @@ public class DatanodeDescriptor extends
*/
public void updateHeartbeat(long capacity, long dfsUsed, long remaining,
long blockPoolUsed, int xceiverCount, int volFailures) {
- this.capacity = capacity;
- this.dfsUsed = dfsUsed;
- this.remaining = remaining;
- this.blockPoolUsed = blockPoolUsed;
- this.lastUpdate = Time.now();
- this.xceiverCount = xceiverCount;
+ setCapacity(capacity);
+ setRemaining(remaining);
+ setBlockPoolUsed(blockPoolUsed);
+ setDfsUsed(dfsUsed);
+ setXceiverCount(xceiverCount);
+ setLastUpdate(Time.now());
this.volumeFailures = volFailures;
this.heartbeatedSinceFailover = true;
- rollBlocksScheduled(lastUpdate);
+ rollBlocksScheduled(getLastUpdate());
}
/**
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java?rev=1399443&r1=1399442&r2=1399443&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
Wed Oct 17 21:34:48 2012
@@ -567,7 +567,7 @@ public class DatanodeManager {
/**
* Decommission the node if it is in exclude list.
*/
- private void checkDecommissioning(DatanodeDescriptor nodeReg, String ipAddr)
{
+ private void checkDecommissioning(DatanodeDescriptor nodeReg) {
// If the registered node is in exclude list, then decommission it
if (inExcludedHostsList(nodeReg)) {
startDecommission(nodeReg);
@@ -713,7 +713,7 @@ public class DatanodeManager {
// also treat the registration message as a heartbeat
heartbeatManager.register(nodeS);
- checkDecommissioning(nodeS, dnAddress);
+ checkDecommissioning(nodeS);
return;
}
@@ -733,7 +733,7 @@ public class DatanodeManager {
= new DatanodeDescriptor(nodeReg, NetworkTopology.DEFAULT_RACK);
resolveNetworkLocation(nodeDescr);
addDatanode(nodeDescr);
- checkDecommissioning(nodeDescr, dnAddress);
+ checkDecommissioning(nodeDescr);
// also treat the registration message as a heartbeat
// no need to update its timestamp
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java?rev=1399443&r1=1399442&r2=1399443&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java
Wed Oct 17 21:34:48 2012
@@ -82,9 +82,9 @@ public class DatanodeRegistration extend
public String toString() {
return getClass().getSimpleName()
+ "(" + getIpAddr()
- + ", storageID=" + storageID
- + ", infoPort=" + infoPort
- + ", ipcPort=" + ipcPort
+ + ", storageID=" + getStorageID()
+ + ", infoPort=" + getInfoPort()
+ + ", ipcPort=" + getIpcPort()
+ ", storageInfo=" + storageInfo
+ ")";
}
