Author: eli
Date: Tue Jan 8 19:51:44 2013
New Revision: 1430468
URL: http://svn.apache.org/viewvc?rev=1430468&view=rev
Log:
HDFS-4031. Update findbugsExcludeFile.xml to include findbugs 2 exclusions.
Contributed by Eli Collins
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1430468&r1=1430467&r2=1430468&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Tue Jan 8
19:51:44 2013
@@ -457,6 +457,9 @@ Release 2.0.3-alpha - Unreleased
HDFS-4030. BlockManager excessBlocksCount and
postponedMisreplicatedBlocksCount should be AtomicLongs. (eli)
+ HDFS-4031. Update findbugsExcludeFile.xml to include findbugs 2
+ exclusions. (eli)
+
OPTIMIZATIONS
BUG FIXES
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml?rev=1430468&r1=1430467&r2=1430468&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
Tue Jan 8 19:51:44 2013
@@ -290,4 +290,22 @@
<Method name="persistPaxosData" />
<Bug pattern="OS_OPEN_STREAM" />
</Match>
+ <!-- Don't complain about LocalDatanodeInfo's anonymous class -->
+ <Match>
+ <Class
name="org.apache.hadoop.hdfs.BlockReaderLocal$LocalDatanodeInfo$1" />
+ <Bug pattern="SE_BAD_FIELD_INNER_CLASS" />
+ </Match>
+ <!-- Only one method increments numFailedVolumes and it is synchronized
-->
+ <Match>
+ <Class
name="org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsVolumeList" />
+ <Field name="numFailedVolumes" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
+ <!-- Access to pendingReceivedRequests is synchronized -->
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.server.datanode.BPServiceActor" />
+ <Method name="notifyNamenodeBlockImmediately" />
+ <Field name="pendingReceivedRequests" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
</FindBugsFilter>
