-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/998/
-----------------------------------------------------------

(Updated 2011-07-28 00:40:14.000447)


Review request for hadoop-hdfs, Dhruba Borthakur and Hairong Kuang.


Changes
-------

Addressed the comments.


Summary
-------

This patch introduces explicit ACKs sent form datanodes to the namenode in 
order to minimize the difference between NN blocks info and DN state.
This will allow for sending the full block reports less frequently, which in 
turn will minimize the overhead of processing them, and blocking the namenode 
for extended time.


This addresses bug HDFS-395.
    https://issues.apache.org/jira/browse/HDFS-395


Diffs (updated)
-----

  
trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
 1151690 
  trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java 
1151690 
  trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java 
1151690 
  
trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDatasetAsyncDiskService.java
 1151690 
  trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java 
1151690 
  trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java 
1151690 
  trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/protocol/BlockCommand.java 
1151690 
  
trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/protocol/DatanodeProtocol.java
 1151690 
  
trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/protocol/ReceivedDeletedBlockInfo.java
 PRE-CREATION 
  
trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
 1151690 
  
trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java
 1151690 

Diff: https://reviews.apache.org/r/998/diff


Testing
-------

Will do JUnit tests.


Thanks,

Tomasz

Reply via email to