I agree that the code has reached a stable point. Colin and Andrew, thank you for your contributions and collaboration.
Throughout development, I've watched the feature grow by running daily builds in a pseudo-distributed deployment. As of this week, the full feature set is working end-to-end. I also think we've reached a point of API stability for clients who want to control caching programmatically. There are several things that I'd like to see completed before the merge as pre-requisites: - HDFS-5203: Concurrent clients that add a cache directive on the same path may prematurely uncache from each other. - HDFS-5385: Caching RPCs are AtMostOnce, but do not persist client ID and call ID to edit log. - HDFS-5386: Add feature documentation for datanode caching. - Standard clean-ups to satisfy Jenkins pre-commit on the merge patch. (For example, I know we've introduced some Javadoc warnings.) - Full test suite run on Windows. (The feature is not yet implemented on Windows. This is just intended to catch regressions.) - Test plan posted to HDFS-4949, similar in scope to the snapshot test plan that was posted to HDFS-2802. For my own part, I've run the new unit tests, and I've tested end-to-end in a pseudo-distributed deployment. It's unlikely that I'll get a chance to test fully distributed before the vote closes, so I'm curious to hear if you've done this on your side yet. Also, I want to confirm that this vote only covers trunk. I don't see branch-2 mentioned, so I assume that we're not voting on merge to branch-2 yet. Before I cast my vote, can you please discuss whether or not it's feasible to complete all of the above in the next 7 days? For the issues assigned to me, I do expect to complete them. Thanks again for all of your hard work! Chris Nauroth Hortonworks http://hortonworks.com/ On Thu, Oct 17, 2013 at 3:07 PM, Colin McCabe <cmcc...@alumni.cmu.edu>wrote: > +1. Thanks, guys. > > best, > Colin > > On Thu, Oct 17, 2013 at 3:01 PM, Andrew Wang <andrew.w...@cloudera.com> > wrote: > > Hello all, > > > > I'd like to call a vote to merge the HDFS-4949 branch (in-memory caching) > > to trunk. Colin McCabe and I have been hard at work the last 3.5 months > > implementing this feature, and feel that it's reached a level of > stability > > and utility where it's ready for broader testing and integration. > > > > I'd also like to thank Chris Nauroth at Hortonworks for code reviews and > > bug fixes, and everyone who's reviewed the HDFS-4949 design doc and left > > comments. > > > > Obviously, I am +1 for the merge. The vote will run the standard 7 days, > > closing on October 24 at 11:59PM. > > > > Thanks, > > Andrew > -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
