[ https://issues.apache.org/jira/browse/HDFS-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andras Bokor resolved HDFS-9353. -------------------------------- Resolution: Not A Problem I checked with my team. We agreed that the comment is ok and no change is needed. > Code and comment mismatch in JavaKeyStoreProvider > --------------------------------------------------- > > Key: HDFS-9353 > URL: https://issues.apache.org/jira/browse/HDFS-9353 > Project: Hadoop HDFS > Issue Type: Task > Reporter: nijel > Assignee: Andras Bokor > Priority: Trivial > > In > org.apache.hadoop.crypto.key.JavaKeyStoreProvider.JavaKeyStoreProvider(URI > uri, Configuration conf) throws IOException > The comment mentioned is > {code} > // Get the password file from the conf, if not present from the user's > // environment var > {code} > But the code takes the value form ENV first > I think this make sense since the user can pass the ENV for a particular run. > My suggestion is to change the comment -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org