Mehran Hassani created HDFS-12808:
-------------------------------------

             Summary: Add LOG.isDebugEnabled() guard for LOG.debug("...")
                 Key: HDFS-12808
                 URL: https://issues.apache.org/jira/browse/HDFS-12808
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: Mehran Hassani
            Priority: Minor


I am conducting research on log related bugs. I tried to make a tool to fix 
repetitive yet simple patterns of bugs that are related to logs. In this file, 
there is a debug level logging statement containing multiple string 
concatenation without the if statement before them: 

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestCachingStrategy.java,
 LOG.debug("got fadvise(offset=" + offset + ", len=" + len +",flags=" + flags + 
")");, 82


Would you be interested in adding the if,  to the logging statement?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to