liaoyuxiangqin created HDFS-13036:
-------------------------------------
Summary: Reusing the volume storage ID obtained by replicaInfo
Key: HDFS-13036
URL: https://issues.apache.org/jira/browse/HDFS-13036
Project: Hadoop HDFS
Issue Type: Improvement
Components: datanode
Affects Versions: 3.1.0
Reporter: liaoyuxiangqin
Assignee: liaoyuxiangqin
When i read the getBlockReports() of FsDatasetImpl class in datanode, i found
the following case code could be more simplify and need't to obtained volume
storage ID by replicaInfo again and again.
{code:title=FsDatasetImpl.java|borderStyle=solid}
switch(b.getState()) {
case FINALIZED:
case RBW:
case RWR:
builders.get(b.getVolume().getStorageID()).add(b);
break;
case RUR:
ReplicaInfo orig = b.getOriginalReplica();
builders.get(b.getVolume().getStorageID()).add(orig);
break;
case TEMPORARY:
break;
default:
assert false : "Illegal ReplicaInfo state.";
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
