Shashikant Banerjee created HDFS-13454: ------------------------------------------
Summary: Ozone : Fix the test logic in TestKeySpaceManager#testDeleteKey Key: HDFS-13454 URL: https://issues.apache.org/jira/browse/HDFS-13454 Project: Hadoop HDFS Issue Type: Sub-task Components: ozone Reporter: Shashikant Banerjee Assignee: Shashikant Banerjee Fix For: HDFS-7240 The test logic in TestKeySpaceManager#testDeleteKey seems to be wrong. The test validates the keyArgs instead of blockId to make sure the key gets deleted from SCM. Also, after the first exception validation , the subsequent statements in the junit never gets executed here. {code:java} keys.add(keyArgs.getResourceName()); exception.expect(IOException.class); exception.expectMessage("Specified block key does not exist"); cluster.getStorageContainerManager().getBlockLocations(keys); // Delete the key again to test deleting non-existing key. // These will never get executed. exception.expect(IOException.class); exception.expectMessage("KEY_NOT_FOUND"); storageHandler.deleteKey(keyArgs); Assert.assertEquals(1 + numKeyDeleteFails, ksmMetrics.getNumKeyDeletesFails());{code} The test needs to be modified to address all these. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org