So.. if we started doing that already.. we can encourage contributors to attach formatted patch.. or create PRs.
And update wiki to follow exact steps to contribute and commit. -Vinay On Thu, 14 Feb 2019, 4:54 pm Steve Loughran <ste...@cloudera.com.invalid wrote: > I've been trying to do that recently, though as it forces me to go to the > command line rather than using Atlassian Sourcetree, I've been getting > other things wrong. To those people who have been dealing with commits I've > managed to mess up: apologies. > > 1. Once someone is down as an author you don't need to add their email > address; the first time you will need to get their email address > 2. Akira, Aaron and I also use the -S option to GPG sign the commits. We > should all be doing that, as it is the way to show who really committed the > patch. Add --show-signature to the end of any git log to command to see > those. > 3. note that if you cherry-pick a patch into a different branch, you have > to use -S in the git cherry-pick command to resign it. > > we should all have our GPG keys in the KEYS file, and co-sign the others in > there, so that we have that mutual trust. > > -Steve > > ps: one flaw in the GPG process: if you ever revoke the key then all > existing commits are considered untrusted > > http://steveloughran.blogspot.com/2017/10/roca-breaks-my-commit-process.html > > > > > On Thu, Feb 14, 2019 at 9:12 AM Akira Ajisaka <aajis...@apache.org> wrote: > > > Hi Vinay, > > > > I'm already doing this if I can get the original author name and the > > email address in some way. > > If the patch is created by git format-patch command, smart-apply-patch > > --committer option can do this automatically. > > > > Never knew that >
