adoroszlai commented on a change in pull request #46: HDDS-2286. Add a log info
in ozone client and scm to print the exclus…
URL: https://github.com/apache/hadoop-ozone/pull/46#discussion_r335815224
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
##########
@@ -176,6 +176,10 @@ public void join() throws InterruptedException {
auditMap.put("owner", owner);
List<AllocatedBlock> blocks = new ArrayList<>(num);
boolean auditSuccess = true;
+ LOG.info("Allocating blocks {} of size {}, with excludeList: " +
+ "datanodes = {}, pipelines = {}, containers = {}",
+ excludeList.getDatanodes(), excludeList.getPipelineIds(),
+ excludeList.getContainerIds());
Review comment:
There are 5 placeholders, but only 3 values. Number and size of blocks
seems to be missing.
Also I think `Allocating {} blocks` would be more natural than `Allocating
blocks {}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
