anuengineer commented on a change in pull request #9: HDDS-2240. Command line
tool for OM Admin
URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r336122003
##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -139,7 +140,8 @@ message OMRequest {
optional MultipartUploadListPartsRequest listMultipartUploadPartsRequest =
50;
optional ServiceListRequest serviceListRequest =
51;
- optional DBUpdatesRequest dbUpdatesRequest =
53;
+ optional OMServerRolesRequest omServerRolesRequest =
52;
+ optional DBUpdatesRequest dbUpdatesRequest =
53;
Review comment:
So today when a client connects to the OM -- it connect reads to get
ServiceList, without this API we cannot communicate to Ozone. So Why would this
info be an independent API, since in my mind this info is needed by the clients
to communicate to OM, since the leader needs to be discovered.
if that is true, then admin command can use the same API do discover the
state right ? do we need a new API in the RPC layer? Perhaps I am missing
something here, Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
